Re: [KJ PATCH] Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in arch/i386/kernel/machine_kexec.c

2007-06-13 Thread Pavel Machek
Hi! > >> Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in > >> arch/i386/kernel/machine_kexec.c. > > > > Please no. > > > > People get creative in copy_page (especially mmx_copy_page), > > and this code path need something simple and stupid, that > > will work every time,

Re: [KJ PATCH] Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in arch/i386/kernel/machine_kexec.c

2007-06-13 Thread Pavel Machek
Hi! Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in arch/i386/kernel/machine_kexec.c. Please no. People get creative in copy_page (especially mmx_copy_page), and this code path need something simple and stupid, that will work every time, especially when things

Re: [KJ PATCH] Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in arch/i386/kernel/machine_kexec.c

2007-06-12 Thread H. Peter Anvin
Eric W. Biederman wrote: > Shani Moideen <[EMAIL PROTECTED]> writes: > >> Hi, >> Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in >> arch/i386/kernel/machine_kexec.c. > > Please no. > > People get creative in copy_page (especially mmx_copy_page), > and this code path need

Re: [KJ PATCH] Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in arch/i386/kernel/machine_kexec.c

2007-06-12 Thread H. Peter Anvin
Eric W. Biederman wrote: Shani Moideen [EMAIL PROTECTED] writes: Hi, Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in arch/i386/kernel/machine_kexec.c. Please no. People get creative in copy_page (especially mmx_copy_page), and this code path need something simple and

Re: [KJ PATCH] Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in arch/i386/kernel/machine_kexec.c

2007-06-11 Thread Eric W. Biederman
Shani Moideen <[EMAIL PROTECTED]> writes: > Hi, > Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in > arch/i386/kernel/machine_kexec.c. Please no. People get creative in copy_page (especially mmx_copy_page), and this code path need something simple and stupid, that will work

[KJ PATCH] Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in arch/i386/kernel/machine_kexec.c

2007-06-11 Thread Shani Moideen
Hi, Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in arch/i386/kernel/machine_kexec.c. Signed-off-by: Shani Moideen <[EMAIL PROTECTED]> diff --git a/arch/i386/kernel/machine_kexec.c b/arch/i386/kernel/machine_kexec.c index 91966ba..ce79a44 100644 ---

[KJ PATCH] Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in arch/i386/kernel/machine_kexec.c

2007-06-11 Thread Shani Moideen
Hi, Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in arch/i386/kernel/machine_kexec.c. Signed-off-by: Shani Moideen [EMAIL PROTECTED] diff --git a/arch/i386/kernel/machine_kexec.c b/arch/i386/kernel/machine_kexec.c index 91966ba..ce79a44 100644 ---

Re: [KJ PATCH] Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in arch/i386/kernel/machine_kexec.c

2007-06-11 Thread Eric W. Biederman
Shani Moideen [EMAIL PROTECTED] writes: Hi, Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in arch/i386/kernel/machine_kexec.c. Please no. People get creative in copy_page (especially mmx_copy_page), and this code path need something simple and stupid, that will work every