Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-26 Thread Laurent Pinchart
Hi Dan, and everybody, Thank you for the patch. On Sat, Jul 04, 2020 at 01:02:51PM -0700, Dan Williams wrote: > Recent events have prompted a Linux position statement on inclusive > terminology. Given that Linux maintains a coding-style and its own > idiomatic set of terminology here is a

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-13 Thread Dan Williams
On Sun, Jul 12, 2020 at 9:26 PM Vinod Koul wrote: > > Hi Mauro, > > On 09-07-20, 13:11, Mauro Carvalho Chehab wrote: > > Em Mon, 06 Jul 2020 06:30:01 -0700 > > Joe Perches escreveu: > > > > > > $ git grep -i -w -P '\w*slave\w*' drivers | \ > > > cut -f1,2 -d/ | uniq -c | sort -rn | head -20 |

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-12 Thread Vinod Koul
Hi Mauro, On 09-07-20, 13:11, Mauro Carvalho Chehab wrote: > Em Mon, 06 Jul 2020 06:30:01 -0700 > Joe Perches escreveu: > > > > $ git grep -i -w -P '\w*slave\w*' drivers | \ > > cut -f1,2 -d/ | uniq -c | sort -rn | head -20 | cat -n > > 1 5683 drivers/net > > 2 2118

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-10 Thread Andy Lutomirski
On Mon, Jul 6, 2020 at 9:30 PM Dan Williams wrote: > > On Sat, Jul 4, 2020 at 5:41 PM Kees Cook wrote: > > > > On Sat, Jul 04, 2020 at 01:02:51PM -0700, Dan Williams wrote: > > > Recent events have prompted a Linux position statement on inclusive > > > terminology. Given that Linux maintains a

Re: [Tech-board-discuss] [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-09 Thread Steven Rostedt
On Thu, 9 Jul 2020 17:13:51 +0100 Mark Brown wrote: > On Thu, Jul 09, 2020 at 10:01:18AM -0600, Shuah Khan wrote: > > On 7/9/20 4:43 AM, Mauro Carvalho Chehab wrote: > > > > For coherency, if "blacklist/whitelist" won't be used anymore, an > > > alternative to graylist should also be

Re: [Tech-board-discuss] [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-09 Thread Mark Brown
On Thu, Jul 09, 2020 at 10:01:18AM -0600, Shuah Khan wrote: > On 7/9/20 4:43 AM, Mauro Carvalho Chehab wrote: > > For coherency, if "blacklist/whitelist" won't be used anymore, an > > alternative to graylist should also be provided. > What is "graylist"? Does it mean in between allow/deny? Yes.

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-09 Thread Mauro Carvalho Chehab
Em Mon, 06 Jul 2020 06:30:01 -0700 Joe Perches escreveu: > On Mon, 2020-07-06 at 09:04 -0400, Matthew Wilcox wrote: > > On Mon, Jul 6, 2020 at 8:59 AM Joe Perches wrote: > > > On Mon, 2020-07-06 at 08:51 -0400, Matthew Wilcox wrote: > > > > In terms of number of lines of code using the

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-08 Thread Daniel Vetter
On Sat, Jul 04, 2020 at 01:02:51PM -0700, Dan Williams wrote: > Recent events have prompted a Linux position statement on inclusive > terminology. Given that Linux maintains a coding-style and its own > idiomatic set of terminology here is a proposal to answer the call to > replace non-inclusive

Re: Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-08 Thread SeongJae Park
On Wed, 8 Jul 2020 00:12:03 -0700 Dan Williams wrote: > On Mon, Jul 6, 2020 at 11:56 PM SeongJae Park wrote: > > > > Hello, > > > > On Sat, 04 Jul 2020 13:02:51 -0700 Dan Williams > > wrote: > > > > > Recent events have prompted a Linux position statement on inclusive > > > terminology. Given

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-08 Thread Dan Williams
On Mon, Jul 6, 2020 at 11:56 PM SeongJae Park wrote: > > Hello, > > On Sat, 04 Jul 2020 13:02:51 -0700 Dan Williams > wrote: > > > Recent events have prompted a Linux position statement on inclusive > > terminology. Given that Linux maintains a coding-style and its own > > idiomatic set of

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-07 Thread Arvind Sankar
On Tue, Jul 07, 2020 at 01:54:23AM -0700, Kees Cook wrote: > On Tue, Jul 07, 2020 at 06:56:53AM +, Harrosh, Boaz wrote: > > Kees Cook wrote: > > > I have struggled with this as well. The parts of speech change, and my > > > grammar senses go weird. whitelist = adjective noun. allow-list = verb

Re: [Tech-board-discuss] [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-07 Thread Steven Rostedt
On Tue, 7 Jul 2020 01:54:23 -0700 Kees Cook wrote: > "I will whitelist the syscall" -- sounds correct to me (same for > "it is whitelisted" or "it is in whitelisting mode"). > > "I will allow-list the syscall" -- sounds wrong to me (same for > "it is allow-listed" or "it is in allow-listing

Re: [Tech-board-discuss] [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-07 Thread Steven Rostedt
On Tue, 7 Jul 2020 09:49:21 +0300 Mike Rapoport wrote: > > But that's all fine. The change is easy to do and is more descriptive > > even if I can't find terms that don't collide with my internal grammar > > checker. ;) > > How about yeslist and nolist? ;-) I was thinking good-list /

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-07 Thread Mark Brown
On Tue, Jul 07, 2020 at 06:56:53AM +, Harrosh, Boaz wrote: > Kees Cook wrote: > > I have struggled with this as well. The parts of speech change, and my > > grammar senses go weird. whitelist = adjective noun. allow-list = verb > > noun. verbing the adj/noun combo feels okay, but verbing a

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-07 Thread Kees Cook
On Tue, Jul 07, 2020 at 06:56:53AM +, Harrosh, Boaz wrote: > Kees Cook wrote: > > I have struggled with this as well. The parts of speech change, and my > > grammar senses go weird. whitelist = adjective noun. allow-list = verb > > noun. verbing the adj/noun combo feels okay, but verbing a

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-07 Thread Christian Brauner
On Sat, Jul 04, 2020 at 01:02:51PM -0700, Dan Williams wrote: > Recent events have prompted a Linux position statement on inclusive > terminology. Given that Linux maintains a coding-style and its own > idiomatic set of terminology here is a proposal to answer the call to > replace non-inclusive

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-07 Thread Harrosh, Boaz
Kees Cook wrote: > I have struggled with this as well. The parts of speech change, and my > grammar senses go weird. whitelist = adjective noun. allow-list = verb > noun. verbing the adj/noun combo feels okay, but verbing a verb/noun is > weird. > And just using "allowed" and "denied" doesn't

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-07 Thread SeongJae Park
Hello, On Sat, 04 Jul 2020 13:02:51 -0700 Dan Williams wrote: > Recent events have prompted a Linux position statement on inclusive > terminology. Given that Linux maintains a coding-style and its own > idiomatic set of terminology here is a proposal to answer the call to > replace

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-07 Thread Mike Rapoport
On Mon, Jul 06, 2020 at 10:56:17PM -0700, Kees Cook wrote: > On Mon, Jul 06, 2020 at 09:29:46AM -0700, Andy Lutomirski wrote: > > Is most contexts where 'whitelist' or 'blacklist' might be used, a > > descriptive phrase could be used instead. For example, a seccomp > > filter could have a 'list

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Kees Cook
On Mon, Jul 06, 2020 at 09:29:46AM -0700, Andy Lutomirski wrote: > Is most contexts where 'whitelist' or 'blacklist' might be used, a > descriptive phrase could be used instead. For example, a seccomp > filter could have a 'list of allowed syscalls' or a 'list of > disallowed syscalls', and just

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Dan Williams
On Mon, Jul 6, 2020 at 9:07 AM Mike Rapoport wrote: > > Hi Chris, > > On Mon, Jul 06, 2020 at 12:45:34PM +, Chris Mason via Ksummit-discuss > wrote: > > On 5 Jul 2020, at 0:55, Willy Tarreau wrote: > > > > > On Sat, Jul 04, 2020 at 01:02:51PM -0700, Dan Williams wrote: > > >> +Non-inclusive

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Dan Williams
On Mon, Jul 6, 2020 at 9:30 AM Andy Lutomirski wrote: > > On Sat, Jul 4, 2020 at 1:19 PM Dan Williams wrote: > > > > Recent events have prompted a Linux position statement on inclusive > > terminology. Given that Linux maintains a coding-style and its own > > idiomatic set of terminology here is

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Andy Lutomirski
On Sat, Jul 4, 2020 at 1:19 PM Dan Williams wrote: > > Recent events have prompted a Linux position statement on inclusive > terminology. Given that Linux maintains a coding-style and its own > idiomatic set of terminology here is a proposal to answer the call to > replace non-inclusive

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Mike Rapoport
Hi Chris, On Mon, Jul 06, 2020 at 12:45:34PM +, Chris Mason via Ksummit-discuss wrote: > On 5 Jul 2020, at 0:55, Willy Tarreau wrote: > > > On Sat, Jul 04, 2020 at 01:02:51PM -0700, Dan Williams wrote: > >> +Non-inclusive terminology has that same distracting effect which is > >> why > >>

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Chris Mason
On 6 Jul 2020, at 10:06, Laurent Pinchart wrote: Hi Chris, On Mon, Jul 06, 2020 at 12:45:34PM +, Chris Mason via Ksummit-discuss wrote: On 5 Jul 2020, at 0:55, Willy Tarreau wrote: Maybe instead of providing an explicit list of a few words it should simply say that terms that take

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Laurent Pinchart
Hi Chris, On Mon, Jul 06, 2020 at 12:45:34PM +, Chris Mason via Ksummit-discuss wrote: > On 5 Jul 2020, at 0:55, Willy Tarreau wrote: > > On Sat, Jul 04, 2020 at 01:02:51PM -0700, Dan Williams wrote: > >> +Non-inclusive terminology has that same distracting effect which is why > >> +it is a

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Joe Perches
On Mon, 2020-07-06 at 09:04 -0400, Matthew Wilcox wrote: > On Mon, Jul 6, 2020 at 8:59 AM Joe Perches wrote: > > On Mon, 2020-07-06 at 08:51 -0400, Matthew Wilcox wrote: > > > In terms of number of lines of code using the word, it's only seventh > > > in drivers/: > > > > > > $ for i in

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Matthew Wilcox
On Mon, Jul 6, 2020 at 8:59 AM Joe Perches wrote: > On Mon, 2020-07-06 at 08:51 -0400, Matthew Wilcox wrote: > > In terms of number of lines of code using the word, it's only seventh > > in drivers/: > > > > $ for i in drivers/*; do c=$(find $i -type f |xargs grep slave |wc > > -l); echo "$c $i";

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Joe Perches
On Mon, 2020-07-06 at 08:51 -0400, Matthew Wilcox wrote: [] > In terms of number of lines of code using the word, it's only seventh > in drivers/: > > $ for i in drivers/*; do c=$(find $i -type f |xargs grep slave |wc > -l); echo "$c $i"; done |sort -rn |head > 5218 drivers/net > 1341 drivers/dma

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Matthew Wilcox
On Mon, Jul 6, 2020 at 3:54 AM Geert Uytterhoeven wrote: > On Mon, Jul 6, 2020 at 9:22 AM Greg Kroah-Hartman > wrote: > > On Mon, Jul 06, 2020 at 05:10:37PM +1000, NeilBrown wrote: > > > On Sat, Jul 04 2020, Matthew Wilcox wrote: > > > > Another suggestion for "slave" replacement should be

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Greg Kroah-Hartman
On Mon, Jul 06, 2020 at 09:53:55AM +0200, Geert Uytterhoeven wrote: > On Mon, Jul 6, 2020 at 9:22 AM Greg Kroah-Hartman > wrote: > > look at the USB spec for an example of these terms being used in this > > way for many decades. > > And when does the "gadget" enter the show? ;-) It doesn't, as

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Geert Uytterhoeven
On Mon, Jul 6, 2020 at 9:22 AM Greg Kroah-Hartman wrote: > On Mon, Jul 06, 2020 at 05:10:37PM +1000, NeilBrown wrote: > > On Sat, Jul 04 2020, Matthew Wilcox wrote: > > > Another suggestion for "slave" replacement should be "device". This is in > > > the context of the w1 bus which is by far the

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Greg Kroah-Hartman
On Mon, Jul 06, 2020 at 05:10:37PM +1000, NeilBrown wrote: > On Sat, Jul 04 2020, Matthew Wilcox wrote: > > > Another suggestion for "slave" replacement should be "device". This is in > > the context of the w1 bus which is by far the largest user of the > > master/slave terminology in the kernel.

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread NeilBrown
On Sat, Jul 04 2020, Matthew Wilcox wrote: > Another suggestion for "slave" replacement should be "device". This is in > the context of the w1 bus which is by far the largest user of the > master/slave terminology in the kernel. Ugh. Please, no. "device" doesn't mean anything, in that you can

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread NeilBrown
On Sat, Jul 04 2020, Matthew Wilcox wrote: > Another suggestion for "slave" replacement should be "device". This is in > the context of the w1 bus which is by far the largest user of the > master/slave terminology in the kernel. Ugh. Please, no. "device" doesn't mean anything, in that you can

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-04 Thread Stephen Rothwell
Hi Dave, On Sun, 5 Jul 2020 12:56:23 +1000 Dave Airlie wrote: > > Sorry I misdirected what you said a bit, and I did misinterpret as > Australia also has it's own indigenous slavery issues, (and non-indigenous :-() > I was trying to stop the "white slavery" is a thing crew from turning > up on

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-04 Thread James Bottomley
On Sun, 2020-07-05 at 12:56 +1000, Dave Airlie wrote: > On Sun, 5 Jul 2020 at 12:12, Stephen Rothwell > wrote: [...] > > > As for the non-black slavery, others have never pointed this out > > > > (I did not say "non-black") > > > > Sorry I misdirected what you said a bit, and I did

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-04 Thread Dave Airlie
On Sun, 5 Jul 2020 at 12:12, Stephen Rothwell wrote: > > Hi Dave, > > On Sun, 5 Jul 2020 09:34:57 +1000 Dave Airlie wrote: > > > > On Sun, 5 Jul 2020 at 06:45, Stephen Rothwell wrote: > > > > > > On Sat, 04 Jul 2020 13:02:51 -0700 Dan Williams > > > wrote: > > > > > > > > +The Linux kernel is

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-04 Thread Dave Airlie
On Sun, 5 Jul 2020 at 10:10, Matthew Wilcox wrote: > > Erm, red-black trees don't have a derivation from gambling terminology > either. The wikipedia article says: > > In a 1978 paper, "A Dichromatic Framework for Balanced Trees",[6] Leonidas J. > Guibas and Robert Sedgewick derived the

Re: [Tech-board-discuss] [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-04 Thread Randy Dunlap
On 7/4/20 6:10 PM, Kees Cook wrote: > On Sat, Jul 04, 2020 at 08:10:33PM -0400, Matthew Wilcox wrote: >> Left-right tree makes no sense. It doesn't distinguish the rbtree from its >> predecessor the avl tree. I don't think it's helpful to rename a standard >> piece of computing terminology unless

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-04 Thread Stephen Rothwell
Hi Dave, On Sun, 5 Jul 2020 09:34:57 +1000 Dave Airlie wrote: > > On Sun, 5 Jul 2020 at 06:45, Stephen Rothwell wrote: > > > > On Sat, 04 Jul 2020 13:02:51 -0700 Dan Williams > > wrote: > > > > > > +The Linux kernel is a global software project, and in 2020 there was a > > > +global

Re: [Tech-board-discuss] [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-04 Thread Kees Cook
On Sat, Jul 04, 2020 at 08:10:33PM -0400, Matthew Wilcox wrote: > Left-right tree makes no sense. It doesn't distinguish the rbtree from its > predecessor the avl tree. I don't think it's helpful to rename a standard > piece of computing terminology unless it's actually hurting us to have it. >

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-04 Thread Dave Airlie
On Sun, 5 Jul 2020 at 06:19, Dan Williams wrote: > > Recent events have prompted a Linux position statement on inclusive > terminology. Given that Linux maintains a coding-style and its own > idiomatic set of terminology here is a proposal to answer the call to > replace non-inclusive

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-04 Thread Dave Airlie
'. Colors to represent a policy requires an indirection. The > > how about: > Using colors to represent a policy requires an indirection. I'd totally submit that red/black trees while in no way racist, are a horrible indirection, as it means nothing if you've never interacted with

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-04 Thread Dave Airlie
On Sun, 5 Jul 2020 at 06:45, Stephen Rothwell wrote: > > Hi Dan, > > On Sat, 04 Jul 2020 13:02:51 -0700 Dan Williams > wrote: > > > > +Linux kernel inclusive terminology > > +== > > + > > +The Linux kernel is a global software project, and in 2020 there was a > >

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-04 Thread Olof Johansson
On Sat, Jul 4, 2020 at 1:19 PM Dan Williams wrote: > > Recent events have prompted a Linux position statement on inclusive > terminology. Given that Linux maintains a coding-style and its own > idiomatic set of terminology here is a proposal to answer the call to > replace non-inclusive

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-04 Thread Stephen Rothwell
Hi Dan, On Sat, 04 Jul 2020 13:02:51 -0700 Dan Williams wrote: > > +Linux kernel inclusive terminology > +== > + > +The Linux kernel is a global software project, and in 2020 there was a > +global reckoning on race relations that caused many organizations to >