RE: [LINUX PATCH 1/4] dmaengine: xilinx_dma: Fix dma_get_slave_caps() API failures

2018-01-02 Thread Appana Durga Kedareswara Rao
Hi Vinod, Thanks for the review... > >On Thu, Dec 21, 2017 at 03:41:35PM +0530, Kedareswara rao Appana wrote: > >Patch title should say what is does, not the cause/effect Sure will fix in v2... > >An apt title might be "populate dma caps properly" > >> When client driver uses

RE: [LINUX PATCH 1/4] dmaengine: xilinx_dma: Fix dma_get_slave_caps() API failures

2018-01-02 Thread Appana Durga Kedareswara Rao
Hi Vinod, Thanks for the review... > >On Thu, Dec 21, 2017 at 03:41:35PM +0530, Kedareswara rao Appana wrote: > >Patch title should say what is does, not the cause/effect Sure will fix in v2... > >An apt title might be "populate dma caps properly" > >> When client driver uses

Re: [LINUX PATCH 1/4] dmaengine: xilinx_dma: Fix dma_get_slave_caps() API failures

2018-01-02 Thread Vinod Koul
On Thu, Dec 21, 2017 at 03:41:35PM +0530, Kedareswara rao Appana wrote: Patch title should say what is does, not the cause/effect An apt title might be "populate dma caps properly" > When client driver uses dma_get_slave_caps() api, > it checks for certain fields of dma_device struct >

Re: [LINUX PATCH 1/4] dmaengine: xilinx_dma: Fix dma_get_slave_caps() API failures

2018-01-02 Thread Vinod Koul
On Thu, Dec 21, 2017 at 03:41:35PM +0530, Kedareswara rao Appana wrote: Patch title should say what is does, not the cause/effect An apt title might be "populate dma caps properly" > When client driver uses dma_get_slave_caps() api, > it checks for certain fields of dma_device struct >

[LINUX PATCH 1/4] dmaengine: xilinx_dma: Fix dma_get_slave_caps() API failures

2017-12-21 Thread Kedareswara rao Appana
When client driver uses dma_get_slave_caps() api, it checks for certain fields of dma_device struct currently driver is not settings few fields resulting dma_get_slave_caps() returning failure. This patch fixes this issue by populating proper values to the struct dma_device fields.

[LINUX PATCH 1/4] dmaengine: xilinx_dma: Fix dma_get_slave_caps() API failures

2017-12-21 Thread Kedareswara rao Appana
When client driver uses dma_get_slave_caps() api, it checks for certain fields of dma_device struct currently driver is not settings few fields resulting dma_get_slave_caps() returning failure. This patch fixes this issue by populating proper values to the struct dma_device fields.