Re: [LINUX PATCH v3] spi: spi-mem: Fix build error without CONFIG_SPI_MEM

2019-04-10 Thread YueHaibing
On 2019/4/10 20:35, Mark Brown wrote: > On Wed, Apr 10, 2019 at 12:30:37PM +, Naga Sureshkumar Relli wrote: > >>> Yeah, I'm surprised that builds... > >> Sorry, I tested with CONFIG_SPI_MEM enabled. It's my bad. > > I also see that I'd queued an earlier version for application. I've > lost

Re: [LINUX PATCH v3] spi: spi-mem: Fix build error without CONFIG_SPI_MEM

2019-04-10 Thread Mark Brown
On Wed, Apr 10, 2019 at 12:30:37PM +, Naga Sureshkumar Relli wrote: > > Yeah, I'm surprised that builds... > Sorry, I tested with CONFIG_SPI_MEM enabled. It's my bad. I also see that I'd queued an earlier version for application. I've lost track of whatever issues there were with that, sorr

RE: [LINUX PATCH v3] spi: spi-mem: Fix build error without CONFIG_SPI_MEM

2019-04-10 Thread Naga Sureshkumar Relli
kernel.org; Michal Simek > ; > nagasures...@gmail.com > Subject: Re: [LINUX PATCH v3] spi: spi-mem: Fix build error without > CONFIG_SPI_MEM > > On Wed, Apr 10, 2019 at 08:22:29PM +0800, YueHaibing wrote: > > On 2019/4/10 19:57, Naga Sureshkumar Relli wrote: > > > > +static

Re: [LINUX PATCH v3] spi: spi-mem: Fix build error without CONFIG_SPI_MEM

2019-04-10 Thread Mark Brown
On Wed, Apr 10, 2019 at 08:22:29PM +0800, YueHaibing wrote: > On 2019/4/10 19:57, Naga Sureshkumar Relli wrote: > > +static inline bool spi_mem_default_supports_op(struct spi_mem *mem, > > +const struct spi_mem_op *op); > Here miss a Function body, right? Yeah, I'm su

Re: [LINUX PATCH v3] spi: spi-mem: Fix build error without CONFIG_SPI_MEM

2019-04-10 Thread YueHaibing
On 2019/4/10 19:57, Naga Sureshkumar Relli wrote: > From: YueHaibing > > When building with CONFIG_SPI_MEM is not set > gc warns this: > > drivers/spi/spi-zynq-qspi.o: In function `zynq_qspi_supports_op': > spi-zynq-qspi.c:(.text+0x1da): undefined reference to > `spi_mem_default_supports_op' >

[LINUX PATCH v3] spi: spi-mem: Fix build error without CONFIG_SPI_MEM

2019-04-10 Thread Naga Sureshkumar Relli
From: YueHaibing When building with CONFIG_SPI_MEM is not set gc warns this: drivers/spi/spi-zynq-qspi.o: In function `zynq_qspi_supports_op': spi-zynq-qspi.c:(.text+0x1da): undefined reference to `spi_mem_default_supports_op' Fixes: 67dca5e580f1 ("spi: spi-mem: Add support for Zynq QSPI contr