Re: [LKP] [mm] 9bc8039e71: will-it-scale.per_thread_ops -64.1% regression

2019-01-30 Thread Waiman Long
On 01/30/2019 07:06 PM, Tim Chen wrote: > On 12/27/18 6:55 PM, Waiman Long wrote: >> On 12/27/2018 08:31 PM, Wang, Kemi wrote: >>> Hi, Waiman >>>Did you post that patch? Let's see if it helps. >> I did post the patch a while ago. I will need to rebase it to a new >> baseline. Will do that in a

Re: [LKP] [mm] 9bc8039e71: will-it-scale.per_thread_ops -64.1% regression

2019-01-30 Thread Tim Chen
On 12/27/18 6:55 PM, Waiman Long wrote: > On 12/27/2018 08:31 PM, Wang, Kemi wrote: >> Hi, Waiman >>Did you post that patch? Let's see if it helps. > > I did post the patch a while ago. I will need to rebase it to a new > baseline. Will do that in a week or 2. > > -Longman > Waiman, In a l

Re: [LKP] [mm] 9bc8039e71: will-it-scale.per_thread_ops -64.1% regression

2018-12-27 Thread kemi
ing ; Andrew Morton >> ; lduf...@linux.vnet.ibm.com; l...@01.org; >> kirill.shute...@linux.intel.com >> Subject: Re: [LKP] [mm] 9bc8039e71: will-it-scale.per_thread_ops -64.1% >> regression >> >> On 11/05/2018 05:14 PM, Linus Torvalds wrote: >>>

Re: [LKP] [mm] 9bc8039e71: will-it-scale.per_thread_ops -64.1% regression

2018-12-27 Thread Waiman Long
ton > ; lduf...@linux.vnet.ibm.com; l...@01.org; > kirill.shute...@linux.intel.com > Subject: Re: [LKP] [mm] 9bc8039e71: will-it-scale.per_thread_ops -64.1% > regression > > On 11/05/2018 05:14 PM, Linus Torvalds wrote: >> On Mon, Nov 5, 2018 at 12:12 PM Vlastimil Babka w

RE: [LKP] [mm] 9bc8039e71: will-it-scale.per_thread_ops -64.1% regression

2018-12-27 Thread Wang, Kemi
ernel Mailing List ; Matthew Wilcox ; mho...@kernel.org; Colin King ; Andrew Morton ; lduf...@linux.vnet.ibm.com; l...@01.org; kirill.shute...@linux.intel.com Subject: Re: [LKP] [mm] 9bc8039e71: will-it-scale.per_thread_ops -64.1% regression On 11/05/2018 05:14 PM, Linus Torvalds wrote: >

Re: [LKP] [mm] 9bc8039e71: will-it-scale.per_thread_ops -64.1% regression

2018-11-05 Thread Waiman Long
On 11/05/2018 05:14 PM, Linus Torvalds wrote: > On Mon, Nov 5, 2018 at 12:12 PM Vlastimil Babka wrote: >> I didn't spot an obvious mistake in the patch itself, so it looks >> like some bad interaction between scheduler and the mmap downgrade? > I'm thinking it's RWSEM_SPIN_ON_OWNER that ends up be

Re: [LKP] [mm] 9bc8039e71: will-it-scale.per_thread_ops -64.1% regression

2018-11-05 Thread Linus Torvalds
On Mon, Nov 5, 2018 at 12:12 PM Vlastimil Babka wrote: > > I didn't spot an obvious mistake in the patch itself, so it looks > like some bad interaction between scheduler and the mmap downgrade? I'm thinking it's RWSEM_SPIN_ON_OWNER that ends up being confused by the downgrade. It looks like the

Re: [LKP] [mm] 9bc8039e71: will-it-scale.per_thread_ops -64.1% regression

2018-11-05 Thread Yang Shi
On 11/5/18 10:35 AM, Linus Torvalds wrote: On Mon, Nov 5, 2018 at 10:28 AM Yang Shi wrote: Actually, the commit is mainly for optimizing the long stall time caused by holding mmap_sem by write when unmapping or shrinking large mapping. It downgrades write mmap_sem to read when zapping pages.

Re: [LKP] [mm] 9bc8039e71: will-it-scale.per_thread_ops -64.1% regression

2018-11-05 Thread Vlastimil Babka
On 11/5/18 6:50 PM, Linus Torvalds wrote: > On Sun, Nov 4, 2018 at 9:08 PM kernel test robot > wrote: >> >> FYI, we noticed a -64.1% regression of will-it-scale.per_thread_ops >> due to commit 9bc8039e715d ("mm: brk: downgrade mmap_sem to read when >> shrinking") > > Ugh. That looks pretty bad.

Re: [LKP] [mm] 9bc8039e71: will-it-scale.per_thread_ops -64.1% regression

2018-11-05 Thread Linus Torvalds
On Mon, Nov 5, 2018 at 10:28 AM Yang Shi wrote: > > Actually, the commit is mainly for optimizing the long stall time caused > by holding mmap_sem by write when unmapping or shrinking large mapping. > It downgrades write mmap_sem to read when zapping pages. So, it looks > the downgrade incurs more

Re: [LKP] [mm] 9bc8039e71: will-it-scale.per_thread_ops -64.1% regression

2018-11-05 Thread Yang Shi
On 11/5/18 9:50 AM, Linus Torvalds wrote: On Sun, Nov 4, 2018 at 9:08 PM kernel test robot wrote: FYI, we noticed a -64.1% regression of will-it-scale.per_thread_ops due to commit 9bc8039e715d ("mm: brk: downgrade mmap_sem to read when shrinking") Ugh. That looks pretty bad. in testcase:

Re: [LKP] [mm] 9bc8039e71: will-it-scale.per_thread_ops -64.1% regression

2018-11-05 Thread Linus Torvalds
On Sun, Nov 4, 2018 at 9:08 PM kernel test robot wrote: > > FYI, we noticed a -64.1% regression of will-it-scale.per_thread_ops > due to commit 9bc8039e715d ("mm: brk: downgrade mmap_sem to read when > shrinking") Ugh. That looks pretty bad. > in testcase: will-it-scale > on test machine: 8 thre