Re: [LKP] [mtd] c4dfa25ab3: kernel_BUG_at_fs/sysfs/file.c

2019-01-07 Thread Boris Brezillon
Hello Linus, On Wed, 2 Jan 2019 11:53:34 -0800 Linus Torvalds wrote: > Hmm.. > > Adding a few more mtd people to the cc. Sorry for the late reply, I don't have access to my @bootlin.com address anymore and it took me some time to realize you had replied to this bug report. > > On Tue, Jan

Re: [LKP] [mtd] c4dfa25ab3: kernel_BUG_at_fs/sysfs/file.c

2019-01-03 Thread Rafael J. Wysocki
On Thu, Jan 3, 2019 at 10:26 AM Greg Kroah-Hartman wrote: > > On Wed, Jan 02, 2019 at 10:44:50PM +0100, Rafael J. Wysocki wrote: > > On Wed, Jan 2, 2019 at 8:53 PM Linus Torvalds > > wrote: > > > > [cut] > > > > > Greg, Rafael: it does strike me that the "BUG_ON()" in > > >

Re: [LKP] [mtd] c4dfa25ab3: kernel_BUG_at_fs/sysfs/file.c

2019-01-03 Thread Greg Kroah-Hartman
On Wed, Jan 02, 2019 at 10:44:50PM +0100, Rafael J. Wysocki wrote: > On Wed, Jan 2, 2019 at 8:53 PM Linus Torvalds > wrote: > > [cut] > > > Greg, Rafael: it does strike me that the "BUG_ON()" in > > sysfs_create_file_ns() could easily have been a > > > > if (WARN_ON(..)) > >

Re: [LKP] [mtd] c4dfa25ab3: kernel_BUG_at_fs/sysfs/file.c

2019-01-02 Thread Rafael J. Wysocki
On Wed, Jan 2, 2019 at 8:53 PM Linus Torvalds wrote: [cut] > Greg, Rafael: it does strike me that the "BUG_ON()" in > sysfs_create_file_ns() could easily have been a > > if (WARN_ON(..)) > return -EINVAL; > > which would have made the machine boot and probably make

Re: [LKP] [mtd] c4dfa25ab3: kernel_BUG_at_fs/sysfs/file.c

2019-01-02 Thread Linus Torvalds
Hmm.. Adding a few more mtd people to the cc. On Tue, Jan 1, 2019 at 4:57 PM kernel test robot wrote: > > FYI, we noticed the following commit (built with gcc-7): > > commit: c4dfa25ab307a277eafa7067cd927fbe4d9be4ba ("mtd: add support for > reading MTD devices via the nvmem API") > > [