Re: [Linaro-mm-sig] [PATCH v4 3/4] mutex: Add ww tests to lib/locking-selftest.c. v4

2013-05-29 Thread Daniel Vetter
On Tue, May 28, 2013 at 11:12 PM, Maarten Lankhorst wrote: >>> +static void ww_test_spin_nest_unlocked(void) >>> +{ >>> +raw_spin_lock_nest_lock(_A, ); >>> +U(A); >>> +} >> I don't quite see the point of this one here ... > It's a lockdep test that was missing. o.base is not locked. So

Re: [Linaro-mm-sig] [PATCH v4 3/4] mutex: Add ww tests to lib/locking-selftest.c. v4

2013-05-29 Thread Daniel Vetter
On Tue, May 28, 2013 at 11:12 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: +static void ww_test_spin_nest_unlocked(void) +{ +raw_spin_lock_nest_lock(lock_A, o.base); +U(A); +} I don't quite see the point of this one here ... It's a lockdep test that was missing.