On Fri, 2007-07-13 at 11:09 +0200, Geert Uytterhoeven wrote: > On Fri, 13 Jul 2007, Andrew Morton wrote: > > On Fri, 13 Jul 2007 10:52:10 +0200 (CEST) Geert Uytterhoeven <[EMAIL > > PROTECTED]> wrote: > > > > > > > Summaries: > > > > > [1] fbdev: extract fb_show_logo_line() > > > > > [2] fbdev: Add fb_append_extra_logo() > > > > > > > > This one does give additional code and data to all fbdev users while > > > > only > > > > being useful to cell machines. Should we fix that? > > > > > > I can protect it by #ifdef CONFIG_PPC_CELL (as long as there are no other > > > users). Would that be OK? > > > > umm, your call. If that makes sense, sure. > > I just don't like putting platform-specific checks in common code. > > Perhaps I better add CONFIG_FB_LOGO_EXTRA and make it depend on > CONFIG_PPC_CELL?
I hate depends when it's not a dependency... the logo extra code doesn't -depend- technically on cell (it doesn't call cell only stuff). However, cell wants it enabled, thus I'd rather use either the "default y if PP_CELL" construct or select it from the cell option. Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
