Re: [Linux-nvdimm] [PATCH] pmem: Add prints at module load and unload

2015-04-07 Thread Boaz Harrosh
On 04/07/2015 06:19 PM, Christoph Hellwig wrote: > On Sun, Apr 05, 2015 at 11:50:06AM +0300, Boaz Harrosh wrote: >> [ +0.000537] pmem: init 2 devices => 0 >> >> So I have all the information. And I know the driver was actually loaded >> successfully on the expected two regions. > > The second num

Re: [Linux-nvdimm] [PATCH] pmem: Add prints at module load and unload

2015-04-07 Thread Christoph Hellwig
On Sun, Apr 05, 2015 at 11:50:06AM +0300, Boaz Harrosh wrote: > [ +0.000537] pmem: init 2 devices => 0 > > So I have all the information. And I know the driver was actually loaded > successfully on the expected two regions. The second number will always be 0, so no point in printing it. Also dev

Re: [Linux-nvdimm] [PATCH] pmem: Add prints at module load and unload

2015-04-05 Thread Boaz Harrosh
On 04/02/2015 07:44 PM, Christoph Hellwig wrote: > On Thu, Apr 02, 2015 at 09:01:14AM -0700, Dan Williams wrote: If anything I think these should be dev_dbg(). >>> >>> We do not have a dev at any of this point, and it does not >>> belong to any specific device. >> >> Ah, true this is prior to

Re: [Linux-nvdimm] [PATCH] pmem: Add prints at module load and unload

2015-04-02 Thread Christoph Hellwig
On Thu, Apr 02, 2015 at 09:01:14AM -0700, Dan Williams wrote: > >> If anything I think these should be dev_dbg(). > > > > We do not have a dev at any of this point, and it does not > > belong to any specific device. > > Ah, true this is prior to the driver attaching... that said it seems > more re

Re: [Linux-nvdimm] [PATCH] pmem: Add prints at module load and unload

2015-04-02 Thread Dan Williams
On Thu, Apr 2, 2015 at 8:47 AM, Boaz Harrosh wrote: > On 04/02/2015 06:39 PM, Dan Williams wrote: >> On Thu, Apr 2, 2015 at 8:31 AM, Boaz Harrosh wrote: >>> Hi Christoph, Ingo >>> >>> Please consider this small patch below just a small print at module >>> load/unload so to know at user systems ho

Re: [Linux-nvdimm] [PATCH] pmem: Add prints at module load and unload

2015-04-02 Thread Boaz Harrosh
On 04/02/2015 06:39 PM, Dan Williams wrote: > On Thu, Apr 2, 2015 at 8:31 AM, Boaz Harrosh wrote: >> Hi Christoph, Ingo >> >> Please consider this small patch below just a small print at module >> load/unload so to know at user systems how things progressed. >> As it is now, we know nothing. For a

Re: [Linux-nvdimm] [PATCH] pmem: Add prints at module load and unload

2015-04-02 Thread Dan Williams
On Thu, Apr 2, 2015 at 8:31 AM, Boaz Harrosh wrote: > Hi Christoph, Ingo > > Please consider this small patch below just a small print at module > load/unload so to know at user systems how things progressed. > As it is now, we know nothing. For any other disk kind we have two > tuns of prints. >