RE: [Linuxarm] Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()

2021-02-12 Thread Song Bao Hua (Barry Song)
> -Original Message- > From: Arnd Bergmann [mailto:a...@kernel.org] > Sent: Saturday, February 13, 2021 9:23 AM > To: Grygorii Strashko > Cc: Song Bao Hua (Barry Song) ; Andy Shevchenko > ; luojiaxing ; Linus > Walleij ; Santosh Shilimkar ; > Kevin Hilman ; open list:GPIO SUBSYSTEM > ;

Re: [Linuxarm] Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()

2021-02-12 Thread Arnd Bergmann
On Fri, Feb 12, 2021 at 12:53 PM Grygorii Strashko wrote: > > The worst RT case I can imagine is when gpio API is still called from hard > IRQ context by some > other device driver - some toggling for example. > Note. RT or "threadirqs" does not mean gpiochip become sleepable. > > In this case:

RE: [Linuxarm] Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()

2021-02-12 Thread Song Bao Hua (Barry Song)
> -Original Message- > From: Grygorii Strashko [mailto:grygorii.stras...@ti.com] > Sent: Saturday, February 13, 2021 3:09 AM > To: Song Bao Hua (Barry Song) ; Andy Shevchenko > > Cc: Arnd Bergmann ; luojiaxing ; Linus > Walleij ; Santosh Shilimkar ; > Kevin Hilman ; open list:GPIO

Re: [Linuxarm] Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()

2021-02-12 Thread Grygorii Strashko
On 12/02/2021 15:12, Song Bao Hua (Barry Song) wrote: -Original Message- From: Grygorii Strashko [mailto:grygorii.stras...@ti.com] Sent: Saturday, February 13, 2021 12:53 AM To: Song Bao Hua (Barry Song) ; Andy Shevchenko Cc: Arnd Bergmann ; luojiaxing ; Linus Walleij ; Santosh

RE: [Linuxarm] Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()

2021-02-12 Thread Song Bao Hua (Barry Song)
> -Original Message- > From: Grygorii Strashko [mailto:grygorii.stras...@ti.com] > Sent: Saturday, February 13, 2021 12:53 AM > To: Song Bao Hua (Barry Song) ; Andy Shevchenko > > Cc: Arnd Bergmann ; luojiaxing ; Linus > Walleij ; Santosh Shilimkar ; > Kevin Hilman ; open list:GPIO

Re: [Linuxarm] Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()

2021-02-12 Thread Grygorii Strashko
On 12/02/2021 13:29, Song Bao Hua (Barry Song) wrote: -Original Message- From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] Sent: Friday, February 12, 2021 11:57 PM To: Song Bao Hua (Barry Song) Cc: Grygorii Strashko ; Arnd Bergmann ; luojiaxing ; Linus Walleij ; Santosh

Re: [Linuxarm] Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()

2021-02-12 Thread Andy Shevchenko
On Fri, Feb 12, 2021 at 11:59:28AM +0100, Arnd Bergmann wrote: > On Fri, Feb 12, 2021 at 11:42 AM Song Bao Hua (Barry Song) > wrote: > > > > Ok, second thought. irqsave before generic_handle_irq() won't defeat > > the purpose of preemption too much as the dispatched irq handlers by > > gpiochip

RE: [Linuxarm] Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()

2021-02-12 Thread Song Bao Hua (Barry Song)
> -Original Message- > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Friday, February 12, 2021 11:57 PM > To: Song Bao Hua (Barry Song) > Cc: Grygorii Strashko ; Arnd Bergmann > ; luojiaxing ; Linus Walleij > ; Santosh Shilimkar ; Kevin > Hilman ; open list:GPIO

Re: [Linuxarm] Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()

2021-02-12 Thread Arnd Bergmann
On Fri, Feb 12, 2021 at 11:42 AM Song Bao Hua (Barry Song) wrote: > > Ok, second thought. irqsave before generic_handle_irq() won't defeat > the purpose of preemption too much as the dispatched irq handlers by > gpiochip will run in their own threads but not in the thread of > gpiochip's handler.

Re: [Linuxarm] Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()

2021-02-12 Thread Andy Shevchenko
On Fri, Feb 12, 2021 at 10:42:19AM +, Song Bao Hua (Barry Song) wrote: > > From: Grygorii Strashko [mailto:grygorii.stras...@ti.com] > > Sent: Friday, February 12, 2021 11:28 PM > > On 12/02/2021 11:45, Arnd Bergmann wrote: > > > On Fri, Feb 12, 2021 at 6:05 AM Song Bao Hua (Barry Song) > > >

RE: [Linuxarm] Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()

2021-02-12 Thread Song Bao Hua (Barry Song)
> -Original Message- > From: Grygorii Strashko [mailto:grygorii.stras...@ti.com] > Sent: Friday, February 12, 2021 11:28 PM > To: Arnd Bergmann ; Song Bao Hua (Barry Song) > > Cc: luojiaxing ; Linus Walleij > ; Andy Shevchenko ; Andy > Shevchenko ; Santosh Shilimkar > ; Kevin Hilman ;

Re: [Linuxarm] Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()

2021-02-12 Thread Grygorii Strashko
Hi Arnd, On 12/02/2021 11:45, Arnd Bergmann wrote: On Fri, Feb 12, 2021 at 6:05 AM Song Bao Hua (Barry Song) wrote: -Original Message- Note. there is also generic_handle_irq() call inside. So generic_handle_irq() is not safe to run in thread thus requires an interrupt-disabled

RE: [Linuxarm] Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()

2021-02-12 Thread Song Bao Hua (Barry Song)
> -Original Message- > From: Arnd Bergmann [mailto:a...@kernel.org] > Sent: Friday, February 12, 2021 10:45 PM > To: Song Bao Hua (Barry Song) > Cc: Grygorii Strashko ; luojiaxing > ; Linus Walleij ; Andy > Shevchenko ; Andy Shevchenko > ; Santosh Shilimkar ; > Kevin Hilman ; open

Re: [Linuxarm] Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()

2021-02-12 Thread Arnd Bergmann
On Fri, Feb 12, 2021 at 6:05 AM Song Bao Hua (Barry Song) wrote: > > -Original Message- > > > > Note. there is also generic_handle_irq() call inside. > > So generic_handle_irq() is not safe to run in thread thus requires > an interrupt-disabled environment to run? If so, I'd rather this

RE: [Linuxarm] Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()

2021-02-11 Thread Song Bao Hua (Barry Song)
> -Original Message- > From: Grygorii Strashko [mailto:grygorii.stras...@ti.com] > Sent: Friday, February 12, 2021 9:17 AM > To: Arnd Bergmann > Cc: luojiaxing ; Linus Walleij > ; Andy Shevchenko ; Andy > Shevchenko ; Santosh Shilimkar > ; Kevin Hilman ; open list:GPIO > SUBSYSTEM ,