Re: [NET]: rt_check_expire() can take a long time, add a cond_resched()

2007-11-17 Thread David Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Sat, 17 Nov 2007 13:56:08 +0100 > Arjan van de Ven <[EMAIL PROTECTED]> writes: > >> > > >> > Its not that cheap. The ChangeLog included my own numbers, on a > >> > Pentium M machine. (i686, 1.6 GHz, 1.5 GB ram) > >> > > >> > Without "if (need_resched())

Re: [NET]: rt_check_expire() can take a long time, add a cond_resched()

2007-11-17 Thread Herbert Xu
Andi Kleen <[EMAIL PROTECTED]> wrote: > >>> > With the extra check (and *much* less function calls), each run >>> > takes 25ms > > ms?!? The numbers sound wrong. Wrong unit? That's quite possible with a huge routing cache. I think that's the reason Eric is doing this in the first place. >> how

Re: [NET]: rt_check_expire() can take a long time, add a cond_resched()

2007-11-17 Thread Andi Kleen
Arjan van de Ven <[EMAIL PROTECTED]> writes: >> > >> > Its not that cheap. The ChangeLog included my own numbers, on a >> > Pentium M machine. (i686, 1.6 GHz, 1.5 GB ram) >> > >> > Without "if (need_resched())" (so calling need_resched() X.XXX.XXX >> > times), each run takes 88ms >> > >> > With

Re: [NET]: rt_check_expire() can take a long time, add a cond_resched()

2007-11-15 Thread Arjan van de Ven
027d Author: Eric Dumazet > >>> <[EMAIL PROTECTED]> AuthorDate: Wed Nov 14 16:14:05 2007 -0800 > >>> Committer: David S. Miller <[EMAIL PROTECTED]> > >>> CommitDate: Wed Nov 14 16:14:05 2007 -0800 > >>> > >>> [NET]: rt_ch

Re: [NET]: rt_check_expire() can take a long time, add a cond_resched()

2007-11-15 Thread Eric Dumazet
: d90bf5a976793edfa88d3bb2393f0231eb8ce1e5 Parent: 66ba886254edbbd9442d30f1eef6f6fb0145027d Author: Eric Dumazet <[EMAIL PROTECTED]> AuthorDate: Wed Nov 14 16:14:05 2007 -0800 Committer: David S. Miller <[EMAIL PROTECTED]> CommitDate: Wed Nov 14 16:14:05 2007 -0800 [NET]: rt_check_expire() can take a long

Re: [NET]: rt_check_expire() can take a long time, add a cond_resched()

2007-11-15 Thread David Miller
From: Arjan van de Ven <[EMAIL PROTECTED]> Date: Thu, 15 Nov 2007 19:38:02 -0800 > On Thu, 15 Nov 2007 04:01:48 GMT > Linux Kernel Mailing List wrote: > > > Using a "if (need_resched())" test before calling > > "cond_resched();" is necessary to avoid spending too much time doing > > the resc

Re: [NET]: rt_check_expire() can take a long time, add a cond_resched()

2007-11-15 Thread Eric Dumazet
: 66ba886254edbbd9442d30f1eef6f6fb0145027d Author: Eric Dumazet <[EMAIL PROTECTED]> AuthorDate: Wed Nov 14 16:14:05 2007 -0800 Committer: David S. Miller <[EMAIL PROTECTED]> CommitDate: Wed Nov 14 16:14:05 2007 -0800 [NET]: rt_check_expire() can take a long time, add a cond_resched()

Re: [NET]: rt_check_expire() can take a long time, add a cond_resched()

2007-11-15 Thread Arjan van de Ven
e5 Parent: > 66ba886254edbbd9442d30f1eef6f6fb0145027d Author: Eric Dumazet > <[EMAIL PROTECTED]> AuthorDate: Wed Nov 14 16:14:05 2007 -0800 > Committer: David S. Miller <[EMAIL PROTECTED]> > CommitDate: Wed Nov 14 16:14:05 2007 -0800 > > [NET]: rt_check_expire() can take a long time,