Re: [NFS] [PATCH] Re: grow_inodes: inode-max limit reached - how to find/fix the inode leak?

2000-09-01 Thread Michael Riepe
On Fri, Sep 01, 2000 at 11:40:31AM +0200, Trond Myklebust wrote: [...] > > nlm_release_file() *does* grab the semaphore. That's the > > problem. > > Which is why I'm proposing a solution: to split it into 2 functions. >1st function does the semaphore manipulations and calls >

Re: [NFS] [PATCH] Re: grow_inodes: inode-max limit reached - how to find/fix the inode leak?

2000-09-01 Thread Trond Myklebust
> " " == Michael Riepe <[EMAIL PROTECTED]> writes: >> Ugh. In that case, my personal preference would be to make >> nlm_release_file() grab the semaphore, then call another >> routine to do f_count-- and possible file cleanup which could >> also be called by

Re: [NFS] [PATCH] Re: grow_inodes: inode-max limit reached - how to find/fix the inode leak?

2000-09-01 Thread Trond Myklebust
" " == Michael Riepe [EMAIL PROTECTED] writes: Ugh. In that case, my personal preference would be to make nlm_release_file() grab the semaphore, then call another routine to do f_count-- and possible file cleanup which could also be called by nlmsvc_traverse_shares(). Call

Re: [NFS] [PATCH] Re: grow_inodes: inode-max limit reached - how to find/fix the inode leak?

2000-08-31 Thread Michael Riepe
On Fri, Sep 01, 2000 at 12:37:21AM +0200, Trond Myklebust wrote: > > " " == Michael Riepe <[EMAIL PROTECTED]> writes: > > > On Thu, Aug 31, 2000 at 03:23:43PM +0200, Trond Myklebust > > wrote: > >> Your patch does not seem correct to me. IMO you should rather > >> be

Re: [NFS] [PATCH] Re: grow_inodes: inode-max limit reached - how to find/fix the inode leak?

2000-08-31 Thread Trond Myklebust
> " " == Michael Riepe <[EMAIL PROTECTED]> writes: > On Thu, Aug 31, 2000 at 03:23:43PM +0200, Trond Myklebust > wrote: >> Your patch does not seem correct to me. IMO you should rather >> be calling nlm_release_file() in both cases where you applied >> 'put_file()'.

Re: [NFS] [PATCH] Re: grow_inodes: inode-max limit reached - how to find/fix the inode leak?

2000-08-31 Thread Trond Myklebust
> " " == Michael Riepe <[EMAIL PROTECTED]> writes: > There is an inode leak in lockd, caused by a reference counting > bug. It will appear when you use DOS/Windows clients to access > a knfsd+lockd based NFS server, and it will crash the server > sooner or later (a DOS

Re: [NFS] [PATCH] Re: grow_inodes: inode-max limit reached - how to find/fix the inode leak?

2000-08-31 Thread Trond Myklebust
" " == Michael Riepe [EMAIL PROTECTED] writes: On Thu, Aug 31, 2000 at 03:23:43PM +0200, Trond Myklebust wrote: Your patch does not seem correct to me. IMO you should rather be calling nlm_release_file() in both cases where you applied 'put_file()'. No. In the

Re: [NFS] [PATCH] Re: grow_inodes: inode-max limit reached - how to find/fix the inode leak?

2000-08-31 Thread Michael Riepe
On Fri, Sep 01, 2000 at 12:37:21AM +0200, Trond Myklebust wrote: " " == Michael Riepe [EMAIL PROTECTED] writes: On Thu, Aug 31, 2000 at 03:23:43PM +0200, Trond Myklebust wrote: Your patch does not seem correct to me. IMO you should rather be calling