Re: [NFS] [PATCH 0/4] add killattr inode operation to allow filesystems to interpret ATTR_KILL_S*ID bits

2007-08-28 Thread Jeff Layton
On Tue, 28 Aug 2007 15:49:51 -0400 Trond Myklebust <[EMAIL PROTECTED]> wrote: > On Tue, 2007-08-28 at 20:11 +0100, Christoph Hellwig wrote: > > Sorry for not replying to the previsious revisions, but I've been out > > for on vacation. > > > > I can't say I like this version. Now we've got callou

Re: [NFS] [PATCH 0/4] add killattr inode operation to allow filesystems to interpret ATTR_KILL_S*ID bits

2007-08-28 Thread Christoph Hellwig
On Tue, Aug 28, 2007 at 03:49:51PM -0400, Trond Myklebust wrote: > Hmm... There has to be an implicit promise here that nobody else will > ever try to set ATTR_KILL_SUID/ATTR_KILL_SGID and ATTR_MODE at the same > time. Currently, that assumption is not there: > > > > if (ia_valid & ATTR_KILL_

Re: [NFS] [PATCH 0/4] add killattr inode operation to allow filesystems to interpret ATTR_KILL_S*ID bits

2007-08-28 Thread Trond Myklebust
On Tue, 2007-08-28 at 20:11 +0100, Christoph Hellwig wrote: > Sorry for not replying to the previsious revisions, but I've been out > for on vacation. > > I can't say I like this version. Now we've got callouts at two rather close > levels which is not very nice from the interface POV. Agreed.