Re: [Openipmi-developer] [PATCH 3/4] IPMI: convert locked counters to atomics

2008-02-20 Thread Corey Minyard
Matt Domsch wrote: On Thu, Feb 14, 2008 at 12:30:51PM -0600, Corey Minyard wrote: From: Konstantin Baydarov <[EMAIL PROTECTED]> Atomics are a lot more efficient and neat than using a lock. per_cpu variables are a lot more efficient and neat than using locks for simple statistics. no

Re: [Openipmi-developer] [PATCH 3/4] IPMI: convert locked counters to atomics

2008-02-16 Thread Matt Domsch
On Thu, Feb 14, 2008 at 12:30:51PM -0600, Corey Minyard wrote: > From: Konstantin Baydarov <[EMAIL PROTECTED]> > > Atomics are a lot more efficient and neat than using a lock. per_cpu variables are a lot more efficient and neat than using locks for simple statistics. no cache line bouncing to in

Re: [Openipmi-developer] [PATCH 3/4] IPMI: convert locked counters to atomics

2008-02-15 Thread Corey Minyard
Peter Zijlstra wrote: On Thu, 2008-02-14 at 12:30 -0600, Corey Minyard wrote: +/* The command didn't have anyone waiting for it. */ +#define IPMI_STAT_unhandled_commands 23 + +/* Invalid data in an event. */ +#define IPMI_STAT_invalid_events 24 + +/* E