Re: [Outreachy kernel] [PATCH 1/3] staging: rtl8192u: Replace "is is" with "is"

2017-03-08 Thread Ian Abbott
On 04/03/17 16:18, Julia Lawall wrote: On Sat, 4 Mar 2017, simran singhal wrote: This patch replace "is is " with "is". The replacement couldn't be automated because sometimes the first "is" was meant to be another word. Signed-off-by: simran singhal ---

Re: [Outreachy kernel] [PATCH 1/3] staging: rtl8192u: Replace "is is" with "is"

2017-03-08 Thread Ian Abbott
On 04/03/17 16:18, Julia Lawall wrote: On Sat, 4 Mar 2017, simran singhal wrote: This patch replace "is is " with "is". The replacement couldn't be automated because sometimes the first "is" was meant to be another word. Signed-off-by: simran singhal ---

Re: [Outreachy kernel] [PATCH 1/3] staging: rtl8192u: Replace "is is" with "is"

2017-03-04 Thread Julia Lawall
On Sat, 4 Mar 2017, simran singhal wrote: > This patch replace "is is " with "is". The replacement couldn't be > automated because sometimes the first "is" was meant to be another > word. > > Signed-off-by: simran singhal > --- >

Re: [Outreachy kernel] [PATCH 1/3] staging: rtl8192u: Replace "is is" with "is"

2017-03-04 Thread Julia Lawall
On Sat, 4 Mar 2017, simran singhal wrote: > This patch replace "is is " with "is". The replacement couldn't be > automated because sometimes the first "is" was meant to be another > word. > > Signed-off-by: simran singhal > --- > drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +- > 1 file

Re: [Outreachy kernel] [PATCH 1/3] staging: rtl8192u: Replace symbolic permissions with octal permissions

2017-02-16 Thread Julia Lawall
On Fri, 17 Feb 2017, simran singhal wrote: > WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. > Consider using octal permissions '0644'. > This warning is detected by checkpatch.pl This one has all the pieces in the right place, but please redo with the suggestions on the

Re: [Outreachy kernel] [PATCH 1/3] staging: rtl8192u: Replace symbolic permissions with octal permissions

2017-02-16 Thread Julia Lawall
On Fri, 17 Feb 2017, simran singhal wrote: > WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. > Consider using octal permissions '0644'. > This warning is detected by checkpatch.pl This one has all the pieces in the right place, but please redo with the suggestions on the