Re: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: Remove useless led_blink_hdl()

2021-04-14 Thread Fabio M. De Francesco
On Wednesday, April 14, 2021 8:05:59 PM CEST Fabio M. De Francesco wrote: > On Wednesday, April 14, 2021 7:57:03 PM CEST Greg Kroah-Hartman wrote: > > On Wed, Apr 14, 2021 at 08:48:09PM +0300, Dan Carpenter wrote: > > > On Wed, Apr 14, 2021 at 07:00:41PM +0200, Greg Kroah-Hartman wrote: > > > > On

Re: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: Remove useless led_blink_hdl()

2021-04-14 Thread Fabio M. De Francesco
On Wednesday, April 14, 2021 7:57:03 PM CEST Greg Kroah-Hartman wrote: > On Wed, Apr 14, 2021 at 08:48:09PM +0300, Dan Carpenter wrote: > > On Wed, Apr 14, 2021 at 07:00:41PM +0200, Greg Kroah-Hartman wrote: > > > On Wed, Apr 14, 2021 at 06:26:14PM +0200, Fabio M. De Francesco wrote: > > > >

Re: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: Remove useless led_blink_hdl()

2021-04-14 Thread Greg Kroah-Hartman
On Wed, Apr 14, 2021 at 08:48:09PM +0300, Dan Carpenter wrote: > On Wed, Apr 14, 2021 at 07:00:41PM +0200, Greg Kroah-Hartman wrote: > > On Wed, Apr 14, 2021 at 06:26:14PM +0200, Fabio M. De Francesco wrote: > > > Removed useless led_blink_hdl() prototype and definition. In wlancmds[] > > > the

Re: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: Remove useless led_blink_hdl()

2021-04-14 Thread Dan Carpenter
On Wed, Apr 14, 2021 at 07:00:41PM +0200, Greg Kroah-Hartman wrote: > On Wed, Apr 14, 2021 at 06:26:14PM +0200, Fabio M. De Francesco wrote: > > Removed useless led_blink_hdl() prototype and definition. In wlancmds[] > > the slot #60 is now set to NULL using the macro GEN_MLME_EXT_HANDLER. This >

Re: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: Remove useless led_blink_hdl()

2021-04-14 Thread Greg Kroah-Hartman
On Wed, Apr 14, 2021 at 06:26:14PM +0200, Fabio M. De Francesco wrote: > Removed useless led_blink_hdl() prototype and definition. In wlancmds[] > the slot #60 is now set to NULL using the macro GEN_MLME_EXT_HANDLER. This > change has not unwanted side effects because the code in rtw_cmd.c checks

Re: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: Remove useless led_blink_hdl()

2021-04-14 Thread Fabio Aiuto
On Wed, Apr 14, 2021 at 06:26:14PM +0200, Fabio M. De Francesco wrote: > Removed useless led_blink_hdl() prototype and definition. In wlancmds[] > the slot #60 is now set to NULL using the macro GEN_MLME_EXT_HANDLER. This > change has not unwanted side effects because the code in rtw_cmd.c checks

[Outreachy kernel] [PATCH v2] staging: rtl8723bs: Remove useless led_blink_hdl()

2021-04-14 Thread Fabio M. De Francesco
Removed useless led_blink_hdl() prototype and definition. In wlancmds[] the slot #60 is now set to NULL using the macro GEN_MLME_EXT_HANDLER. This change has not unwanted side effects because the code in rtw_cmd.c checks if the function pointer is valid before using it. Reported-by: Julia Lawall