From: Freddy Xin
Date: Sat, 2 Mar 2013 18:41:11 +0800
> From: Freddy Xin
>
> This is a resubmission.
> Added kfree() in ax88179_get_eeprom to prevent memory leakage.
> Modified "__le16 rxctl" to "u16 rxctl" in "struct ax88179_data" and removed
> pointless casts.
> Removed asix_init and asix_e
From: Freddy Xin
This is a resubmission.
Added kfree() in ax88179_get_eeprom to prevent memory leakage.
Modified "__le16 rxctl" to "u16 rxctl" in "struct ax88179_data" and removed
pointless casts.
Removed asix_init and asix_exit functions and added
"module_usb_driver(ax88179_178a_driver)".
Fixe
From: Freddy Xin
Date: Wed, 27 Feb 2013 20:01:58 +0800
> + eeprom_buff = kmalloc(sizeof(u16) * (last_word - first_word + 1),
> + GFP_KERNEL);
> + if (!eeprom_buff)
> + return -ENOMEM;
> +
> + /* ax88179/178A returns 2 bytes from eeprom on read */
From: Freddy Xin
This is a resubmission.
Fixed endianness issue on big endian systems and verified this driver on iBook
G4.
Removed steps that change net->features in ax88179_set_features function.
Added "const" to ethtool_ops structure and fixed the coding style of
AX88179_BULKIN_SIZE array.
F
From: "David Laight"
Date: Fri, 8 Feb 2013 10:23:08 -
> It is much better to define constants for the bit values and
> explicitly mask them as required.
Yes, __be32/__le32 along with bit define macros is the only reasonable
way to do this kind of stuff.
--
To unsubscribe from this list: send
> > +struct ax88179_rx_pkt_header {
> > + u8 l4_csum_err:1,
> > + l3_csum_err:1,
> > + l4_type:3,
> > + l3_type:2,
> > + ce:1;
> > +
> > + u8 vlan_ind:3,
> > + rx_ok:1,
> > + pri:3,
> > + bmc:1;
> > +
> > + u16
On 02/08/2013 04:02 AM, Ben Hutchings wrote:
On Thu, 2013-02-07 at 21:39 +0800, Freddy Xin wrote:
From: Freddy Xin
This is a resubmission.
Added "const" to ethtool_ops structure and fixed the coding style of
AX88179_BULKIN_SIZE array.
Fixed the issue that the default MTU is not 1500.
Added ax
From: Ben Hutchings
Date: Thu, 7 Feb 2013 20:02:55 +
> On Thu, 2013-02-07 at 21:39 +0800, Freddy Xin wrote:
>> From: Freddy Xin
>>
>> This is a resubmission.
>> Added "const" to ethtool_ops structure and fixed the coding style of
>> AX88179_BULKIN_SIZE array.
>> Fixed the issue that the de
On Thu, 2013-02-07 at 21:39 +0800, Freddy Xin wrote:
> From: Freddy Xin
>
> This is a resubmission.
> Added "const" to ethtool_ops structure and fixed the coding style of
> AX88179_BULKIN_SIZE array.
> Fixed the issue that the default MTU is not 1500.
> Added ax88179_change_mtu function and enab
From: Freddy Xin
This is a resubmission.
Added "const" to ethtool_ops structure and fixed the coding style of
AX88179_BULKIN_SIZE array.
Fixed the issue that the default MTU is not 1500.
Added ax88179_change_mtu function and enabled the hardware jumbo frame function
to support an
MTU higher tha
On 02/07/2013 01:46 PM, Stephen Hemminger wrote:
On Thu, 7 Feb 2013 12:36:34 +0800
Freddy Xin wrote:
+static struct ethtool_ops ax88179_ethtool_ops = {
+ .get_link = ethtool_op_get_link,
+ .get_msglevel = usbnet_get_msglevel,
+ .set_msglevel
On 02/07/2013 01:45 PM, Stephen Hemminger wrote:
On Thu, 7 Feb 2013 12:36:34 +0800
Freddy Xin wrote:
+struct {unsigned char ctrl, timer_l, timer_h, size, ifg; }
+AX88179_BULKIN_SIZE[] ={
+ {7, 0x4f, 0,0x12, 0xff},
+ {7, 0xf0, 1,0x15, 0xff},
+ {7, 0xae, 7,
On Thu, 7 Feb 2013 12:36:34 +0800
Freddy Xin wrote:
> +static struct ethtool_ops ax88179_ethtool_ops = {
> + .get_link = ethtool_op_get_link,
> + .get_msglevel = usbnet_get_msglevel,
> + .set_msglevel = usbnet_set_msglevel,
> + .get_wol
On Thu, 7 Feb 2013 12:36:34 +0800
Freddy Xin wrote:
> +struct {unsigned char ctrl, timer_l, timer_h, size, ifg; }
> +AX88179_BULKIN_SIZE[] = {
> + {7, 0x4f, 0,0x12, 0xff},
> + {7, 0xf0, 1,0x15, 0xff},
> + {7, 0xae, 7,0x18, 0xff},
> + {7, 0xcc, 0x4c, 0x18, 8},
> +
From: Freddy Xin
This is a resubmission.
Fixed the issue that the default MTU is not 1500.
Added ax88179_change_mtu function and enabled the hardware jumbo frame function
to support an
MTU higher than 1500.
Fixed indentation and empty line coding style errors.
The _nopm version usb functions wer
-Original Message-
From: Daniel J Blueman [mailto:dan...@quora.org]
Sent: Sunday, February 03, 2013 10:22 PM
To: Freddy Xin
Cc: Linux Kernel
Subject: Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0
to gigabit ethernet adapter driver
> Hi Freddy,
> Michael, cou
Hi Freddy,
> Michael, could you give me more information about how do you test this driver?
> I have tried to reproduce the issue by using "ifconfig ethX mtu 1500", but I
> didn't confront the same issue.
> Thank you in advance for your help.
I found the same by just starting with 'ifconfig eth0
On Mon, 28 Jan 2013 21:36:20 +0800
"Freddy" wrote:
> > I would vote to not accept that driver for mainline as long as this
> > issues are not fixed.
>
>
> Michael, could you give me more information about how do you test
> this driver? I have tried to reproduce the issue by using "ifconfig
> e
"Freddy" writes:
> Bjørn, I am trying to reproduce the issue mentioned by Michael and I
> have a question about submitting this driver.
>
> Should I merge this driver into asix_devices.c and asix_common.c even
> through the usb command, tx_fixup, and rx_fixup functions are totally
> different?
T
> I would vote to not accept that driver for mainline as long as this
> issues are not fixed.
Michael, could you give me more information about how do you test this driver?
I have tried to reproduce the issue by using "ifconfig ethX mtu 1500", but I
didn't confront the same issue.
Thank you in
Hello Michael,
Michael Leun writes:
> I would vote to not accept that driver for mainline as long as this
> issues are not fixed.
>
> The vendor should not be able to claim "hooray, hooray, great device,
> we even have an driver in linux main line" when it is actually such an
> useless crap.
W
On Wed, 23 Jan 2013 10:32:17 +0800
Freddy Xin wrote:
> This is a resubmission.
> Fixed coding style errors.
[...]
> This patch adds a driver for ASIX's AX88179 family of USB 3.0/2.0
> to gigabit ethernet adapters. It's based on the AX88xxx driver but
I hope, there is some error/mistake on my sid
From: Freddy Xin
Date: Wed, 23 Jan 2013 10:32:17 +0800
> Fixed coding style errors.
There are still many style issues remaining, you have a lot more
work to do, for example:
> + return fn(dev, cmd, USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
> +value, index, data, size);
>
From: Freddy Xin
This is a resubmission.
Fixed coding style errors.
The _nopm version usb functions were added to access register in suspend and
resume functions.
Serveral variables allocted dynamically were removed and replaced by stack
variables.
ax88179_get_eeprom were modified from asix_get
On Fri, 18 Jan 2013, David Miller wrote:
> > + ret = fn(dev, cmd, USB_DIR_IN | USB_TYPE_VENDOR |
> > + USB_RECIP_DEVICE, value, index, data, size);
>
> This is not indented properly. When a function call takes up
> multiple lines, the text on the second and subsequent lines m
From: Freddy Xin
Date: Thu, 17 Jan 2013 17:32:54 +0800
> +struct ax88179_rx_pkt_header {
> +
> + u8 l4_csum_err:1,
Get rid of such extraneous empty lines. They do not add clarity,
rather they just take up space.
> + ret = fn(dev, cmd, USB_DIR_IN | USB_TYPE_VENDOR |
> +
This is a resubmission.
The _nopm version usb functions were added to access register in suspend and
resume functions.
Serveral variables allocted dynamically were removed and replaced by stack
variables.
ax88179_get_eeprom were modified from asix_get_eeprom in asix_common.
This patch adds a dr
27 matches
Mail list logo
