Re: [PATCH, take2] VFS : Delay the dentry name generation on sockets and pipes.

2007-03-09 Thread Linus Torvalds
On Fri, 9 Mar 2007, Eric Dumazet wrote: > > CAUTION : d_path() logic is quite tricky. > The correct way to return for example "Hello" is to put it > at the end of the buffer, and returns a pointer to the first char. Yeah, it's subtle, since it wants to use a single buffer,

[PATCH, take2] VFS : Delay the dentry name generation on sockets and pipes.

2007-03-09 Thread Eric Dumazet
Hi Andrew Please find a new version of this patch : I realized d_path() has very uncommon semantic (it seems nobody caught the point in previous patches), and had to change the documentation and pipefs_dname() / sockfs_dname() accordingly. Now, readlink("/proc/pid/fd/xx", buffer, 4096)

[PATCH, take2] VFS : Delay the dentry name generation on sockets and pipes.

2007-03-09 Thread Eric Dumazet
Hi Andrew Please find a new version of this patch : I realized d_path() has very uncommon semantic (it seems nobody caught the point in previous patches), and had to change the documentation and pipefs_dname() / sockfs_dname() accordingly. Now, readlink(/proc/pid/fd/xx, buffer, 4096) returns

Re: [PATCH, take2] VFS : Delay the dentry name generation on sockets and pipes.

2007-03-09 Thread Linus Torvalds
On Fri, 9 Mar 2007, Eric Dumazet wrote: CAUTION : d_path() logic is quite tricky. The correct way to return for example Hello is to put it at the end of the buffer, and returns a pointer to the first char. Yeah, it's subtle, since it wants to use a single buffer, and