Re: [PATCH/RFC] clk: gate: Add some kunit test suites

2020-05-05 Thread Vaittinen, Matti
On Mon, 2020-05-04 at 13:19 -0700, Brendan Higgins wrote: > On Sun, May 3, 2020 at 10:54 PM Vaittinen, Matti > wrote: > > On Wed, 2020-04-29 at 12:15 +0800, David Gow wrote: > > > On Tue, Apr 14, 2020 at 7:46 PM Vaittinen, Matti > > > wrote: > > > > Hello Stephen & All, > > > > > > > >

Re: [PATCH/RFC] clk: gate: Add some kunit test suites

2020-05-04 Thread Brendan Higgins
On Sun, May 3, 2020 at 10:54 PM Vaittinen, Matti wrote: > > Hello David, & All > > This review and mail is more for pointing out the downsides of UTs. I > am not demanding any changes, these comments can be seen as 'nit's. Understood. > On Wed, 2020-04-29 at 12:15 +0800, David Gow wrote: > > On

Re: [PATCH/RFC] clk: gate: Add some kunit test suites

2020-05-03 Thread Vaittinen, Matti
Hello David, & All This review and mail is more for pointing out the downsides of UTs. I am not demanding any changes, these comments can be seen as 'nit's. On Wed, 2020-04-29 at 12:15 +0800, David Gow wrote: > On Tue, Apr 14, 2020 at 7:46 PM Vaittinen, Matti > wrote: > > Hello Stephen & All, >

Re: [PATCH/RFC] clk: gate: Add some kunit test suites

2020-04-28 Thread David Gow
On Tue, Apr 14, 2020 at 7:46 PM Vaittinen, Matti wrote: > > Hello Stephen & All, > > Prologue: > > I have been traumatized in the past - by unit tests :) Thus I am always > a bit jumpy when I see people adding UTs. I always see the inertia UTs > add to development - when people change anything