Re: [PATCH/RFC] samples/: move kprobes sources to samples

2007-09-25 Thread Sam Ravnborg
Hi Ananth. > o Removed samples/Kbuild so the build goes on fine You could have added the obj-y assignment to Kbuild for the same effect. Kbuild is the first filename searched by kbuild, next is Makefile. Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH/RFC] samples/: move kprobes sources to samples

2007-09-25 Thread Ananth N Mavinakayanahalli
On Tue, Sep 25, 2007 at 09:57:11AM +0100, Christoph Hellwig wrote: > On Tue, Sep 25, 2007 at 02:13:33PM +0530, Ananth N Mavinakayanahalli wrote: > > +++ linux-2.6.23-rc7/samples/kprobes/jprobe_example.c > > @@ -0,0 +1,69 @@ > > +/*jprobe-example.c */ > > I don't think we should have this type of c

Re: [PATCH/RFC] samples/: move kprobes sources to samples

2007-09-25 Thread Christoph Hellwig
On Tue, Sep 25, 2007 at 02:13:33PM +0530, Ananth N Mavinakayanahalli wrote: > +++ linux-2.6.23-rc7/samples/kprobes/jprobe_example.c > @@ -0,0 +1,69 @@ > +/*jprobe-example.c */ I don't think we should have this type of comment in any of the files. > +#include > +#include > +#include > +#include

Re: [PATCH/RFC] samples/: move kprobes sources to samples

2007-09-25 Thread Ananth N Mavinakayanahalli
On Mon, Sep 24, 2007 at 02:58:28PM -0700, Randy Dunlap wrote: > > This is RFC patch 2/2. > Patch 1/2 introduces the samples/ infrastructure: > http://lkml.org/lkml/2007/9/24/397 > > > --- > > From: Randy Dunlap <[EMAIL PROTECTED]> > > Move kprobes source files from Documentation/kprobes.txt

Re: [PATCH/RFC] samples/: move kprobes sources to samples

2007-09-24 Thread Mathieu Desnoyers
* Randy Dunlap ([EMAIL PROTECTED]) wrote: > Mathieu Desnoyers wrote: > >* Randy Dunlap ([EMAIL PROTECTED]) wrote: > >>This is RFC patch 2/2. > >>Patch 1/2 introduces the samples/ infrastructure: > >> http://lkml.org/lkml/2007/9/24/397 > >> > > > >Hi Randy, > > > >I got this when building my marker

Re: [PATCH/RFC] samples/: move kprobes sources to samples

2007-09-24 Thread Randy Dunlap
On Tue, 25 Sep 2007 00:24:00 +0200 roel wrote: > I could only point to three nitpicks Yes, hopefully the kprobes people will chime in here sometime and merge those as well, or just ack them and I can change the code. Thanks. --- ~Randy Phaedrus says that Quality is about caring. - To unsubscri

Re: [PATCH/RFC] samples/: move kprobes sources to samples

2007-09-24 Thread Randy Dunlap
Mathieu Desnoyers wrote: * Randy Dunlap ([EMAIL PROTECTED]) wrote: This is RFC patch 2/2. Patch 1/2 introduces the samples/ infrastructure: http://lkml.org/lkml/2007/9/24/397 Hi Randy, I got this when building my markers (which looks alike your kprobes): ld: samples/built-in.o: No such fi

Re: [PATCH/RFC] samples/: move kprobes sources to samples

2007-09-24 Thread roel
I could only point to three nitpicks Randy Dunlap wrote: > This is RFC patch 2/2. > Patch 1/2 introduces the samples/ infrastructure: > http://lkml.org/lkml/2007/9/24/397 > > > --- > > From: Randy Dunlap <[EMAIL PROTECTED]> > > Move kprobes source files from Documentation/kprobes.txt to > s

Re: [PATCH/RFC] samples/: move kprobes sources to samples

2007-09-24 Thread Mathieu Desnoyers
* Randy Dunlap ([EMAIL PROTECTED]) wrote: > > This is RFC patch 2/2. > Patch 1/2 introduces the samples/ infrastructure: > http://lkml.org/lkml/2007/9/24/397 > Hi Randy, I got this when building my markers (which looks alike your kprobes): ld: samples/built-in.o: No such file: No such file o

[PATCH/RFC] samples/: move kprobes sources to samples

2007-09-24 Thread Randy Dunlap
This is RFC patch 2/2. Patch 1/2 introduces the samples/ infrastructure: http://lkml.org/lkml/2007/9/24/397 --- From: Randy Dunlap <[EMAIL PROTECTED]> Move kprobes source files from Documentation/kprobes.txt to samples/kprobes/ and add them to the build system. Fix sparse warnings in all 3