Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-29 Thread Heiko Carstens
On Wed, Jan 28, 2015 at 06:57:54AM -0500, Steven Rostedt wrote: > On Wed, 28 Jan 2015 06:36:45 +0100 > Heiko Carstens wrote: > > > On Tue, Jan 27, 2015 at 09:42:28AM -0500, Steven Rostedt wrote: > > > On Tue, 27 Jan 2015 07:19:42 +0100 > > > Dominik Vogt wrote: > > > > > > > While the kernel m

Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-28 Thread Steven Rostedt
On Wed, 28 Jan 2015 13:18:33 +0100 Heiko Carstens wrote: > Ok, then we'll put that on the s390 tree for the next merge window, so > we can fix any potential fallout easier. > I'll add your Acked-by to all three patches. The notrace patch is the > only one that I changed (see below). > Yep, loo

Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-28 Thread Steven Rostedt
On Wed, 28 Jan 2015 06:36:45 +0100 Heiko Carstens wrote: > On Tue, Jan 27, 2015 at 09:42:28AM -0500, Steven Rostedt wrote: > > On Tue, 27 Jan 2015 07:19:42 +0100 > > Dominik Vogt wrote: > > > > > While the kernel may use only profiling or hotpatch at the same > > > time, Gcc is able to generat

Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-27 Thread Heiko Carstens
On Tue, Jan 27, 2015 at 09:42:28AM -0500, Steven Rostedt wrote: > On Tue, 27 Jan 2015 07:19:42 +0100 > Dominik Vogt wrote: > > > While the kernel may use only profiling or hotpatch at the same > > time, Gcc is able to generate both for the same function. > > Understood, but would that be useful

Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-27 Thread Steven Rostedt
On Tue, 27 Jan 2015 07:19:42 +0100 Dominik Vogt wrote: > While the kernel may use only profiling or hotpatch at the same > time, Gcc is able to generate both for the same function. Understood, but would that be useful for the kernel? -- Steve -- To unsubscribe from this list: send the line "u

Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-26 Thread Dominik Vogt
On Mon, Jan 26, 2015 at 09:37:01AM -0500, Steven Rostedt wrote: > On Mon, 26 Jan 2015 13:54:53 +0100 > Heiko Carstens wrote: > > s390 will use the hotpatch attribute for function tracing, therefore > > introduce a nohotpatch define, depending on CC_USING_HOTPATCH, and add it > > to the existing no

Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-26 Thread Heiko Carstens
On Mon, Jan 26, 2015 at 10:22:26AM -0500, Steven Rostedt wrote: > On Mon, 26 Jan 2015 16:03:19 +0100 > Heiko Carstens wrote: > > > Actually they should be mutually exclusive. I just merged them "just in > > case". > > > > So something like this > > > > #ifdef CC_USING_HOTPATCH > > #define notr

Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-26 Thread Steven Rostedt
On Mon, 26 Jan 2015 16:03:19 +0100 Heiko Carstens wrote: > Actually they should be mutually exclusive. I just merged them "just in case". > > So something like this > > #ifdef CC_USING_HOTPATCH > #define notrace __attribute__((hotpatch(0,0))) > #else > #define notrace __attribute__((no_instrume

Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-26 Thread Heiko Carstens
On Mon, Jan 26, 2015 at 09:37:01AM -0500, Steven Rostedt wrote: > On Mon, 26 Jan 2015 13:54:53 +0100 > Heiko Carstens wrote: > > > gcc supports an s390 specific function attribute called "hotpatch". > > It can be used to specify the number of halfwords that shall be added before > > and after a f

Re: [PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-26 Thread Steven Rostedt
On Mon, 26 Jan 2015 13:54:53 +0100 Heiko Carstens wrote: > gcc supports an s390 specific function attribute called "hotpatch". > It can be used to specify the number of halfwords that shall be added before > and after a function that shall be filled with nops for runtime patching. > > s390 will

[PATCH/RFC 2/3] ftrace: introduce nohotpatch function attribute

2015-01-26 Thread Heiko Carstens
gcc supports an s390 specific function attribute called "hotpatch". It can be used to specify the number of halfwords that shall be added before and after a function that shall be filled with nops for runtime patching. s390 will use the hotpatch attribute for function tracing, therefore introduce