Re: [PATCH/RFC 2.6.21 1/5] ehca: declaration of queue structures

2007-01-11 Thread Christoph Hellwig
On Thu, Jan 11, 2007 at 11:17:21AM -0800, Roland Dreier wrote: > > This indentation changes moves away from the preffered form. > > I will fix when I merge it -- no need to resend. > > > Except for that the patch looks fine. > > Christoph, did you look over all 5 or just this one so far? I've

Re: [PATCH/RFC 2.6.21 1/5] ehca: declaration of queue structures

2007-01-11 Thread Roland Dreier
> This indentation changes moves away from the preffered form. I will fix when I merge it -- no need to resend. > Except for that the patch looks fine. Christoph, did you look over all 5 or just this one so far? Thanks, Roland - To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH/RFC 2.6.21 1/5] ehca: declaration of queue structures

2007-01-11 Thread Christoph Hellwig
On Thu, Jan 11, 2007 at 08:07:49PM +0100, Hoang-Nam Nguyen wrote: > -#define ehca_alloc_fw_ctrlblock(flags) ((void *) get_zeroed_page(flags)) > +#define ehca_alloc_fw_ctrlblock(flags) ((void*) get_zeroed_page(flags)) This indentation changes moves away from the preffered form. Except for that the

[PATCH/RFC 2.6.21 1/5] ehca: declaration of queue structures

2007-01-11 Thread Hoang-Nam Nguyen
Hello Roland and Christoph H.! This is a patch for ehca structs. It enhances completion queue and queue pair with use counters for associated mmap-ed resources, ie. hardware register block and queue pages. Furthermore it removes redundant prototypes. Thanks Nam Signed-off-by Hoang-Nam Nguyen <[EM