Re: [PATCH: 2.6.11-rc5] i2c chips: ds1337 RTC driver

2005-03-04 Thread Jean Delvare
Hi James, all, > Revised patch is attached. Looks all OK to me. Thanks, -- Jean Delvare - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH: 2.6.11-rc5] i2c chips: ds1337 RTC driver

2005-03-03 Thread James Chapman
Revised patch is attached. Jean Delvare wrote: Hi James, A revised ds1337 patch addressing all of Jean's comments is attached. Fine with me except for: + if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA | +I2C_FUNC_SMBUS_I2C_BLOCK)) I don'

Re: [PATCH: 2.6.11-rc5] i2c chips: ds1337 RTC driver

2005-03-03 Thread Jean Delvare
Hi James, > A revised ds1337 patch addressing all of Jean's comments is attached. Fine with me except for: > + if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA | > + I2C_FUNC_SMBUS_I2C_BLOCK)) I don't this it is correct. You are using master_xf

Re: [PATCH: 2.6.11-rc5] i2c chips: ds1337 RTC driver

2005-03-03 Thread James Chapman
A revised ds1337 patch addressing all of Jean's comments is attached. i2c: add ds1337 RTC chip support Signed-off-by: James Chapman <[EMAIL PROTECTED]> Index: linux-2.6.i2c/drivers/i2c/chips/ds1337.c === --- /dev/null 1970-01-01 00

Re: [PATCH: 2.6.11-rc5] i2c chips: ds1337 RTC driver

2005-03-02 Thread Andrew Morton
James Chapman <[EMAIL PROTECTED]> wrote: > > Add DS1337 RTC chip driver. > drivers/i2c/chips/ds1337.c:60: `I2C_DRIVERID_DS1337' undeclared here (not in a function) Also, there are changes in Greg's i2c tree which break your new driver: drivers/i2c/chips/ds1337.c:60: initializer element is not

Re: [PATCH: 2.6.11-rc5] i2c chips: ds1337 RTC driver

2005-03-02 Thread Greg KH
On Tue, Mar 01, 2005 at 07:21:56PM +, James Chapman wrote: > Revised ds1337 chip driver patch. > > Signed-off-by: James Chapman <[EMAIL PROTECTED]> > > - change all driver log messages to use dev_dbg() or dev_err() > - remove debug module parameter Hm, doesn't seem to apply at all: drivers/

Re: [PATCH: 2.6.11-rc5] i2c chips: ds1337 RTC driver

2005-03-02 Thread Jean Delvare
Hi James, > diff -Nru a/drivers/i2c/chips/Kconfig b/drivers/i2c/chips/Kconfig > --- a/drivers/i2c/chips/Kconfig 2005-02-27 20:42:22 +00:00 > +++ b/drivers/i2c/chips/Kconfig 2005-02-27 20:42:22 +00:00 > @@ -62,6 +62,17 @@ > This driver can also be built as a module. If so, the

Re: [PATCH: 2.6.11-rc5] i2c chips: ds1337 RTC driver

2005-03-01 Thread James Chapman
Revised ds1337 chip driver patch. Signed-off-by: James Chapman <[EMAIL PROTECTED]> - change all driver log messages to use dev_dbg() or dev_err() - remove debug module parameter Greg KH wrote: On Mon, Feb 28, 2005 at 05:14:25PM +, James Chapman wrote: +/* Define to compile in pr_debug() trace *

Re: [PATCH: 2.6.11-rc5] i2c chips: ds1337 RTC driver

2005-03-01 Thread Greg KH
On Mon, Feb 28, 2005 at 05:14:25PM +, James Chapman wrote: > +/* Define to compile in pr_debug() trace */ > +#undef DEBUG Not needed, we do this in the makefile now. > + if (debug >= 1) > + pr_debug("%s: client=%p, dt=%p\n", __FUNCTION__, client, dt); Please use the dev_dbg()

[PATCH: 2.6.11-rc5] i2c chips: ds1337 RTC driver

2005-02-28 Thread James Chapman
Add DS1337 RTC chip driver. Signed-off-by: James Chapman <[EMAIL PROTECTED]> diff -Nru a/drivers/i2c/chips/Kconfig b/drivers/i2c/chips/Kconfig --- a/drivers/i2c/chips/Kconfig 2005-02-27 20:42:22 +00:00 +++ b/drivers/i2c/chips/Kconfig 2005-02-27 20:42:22 +00:00 @@ -62,6 +62,17 @@ This dri