Re: [PATCH: V2 1/2] gpio: tc35894: fix up tc35894 interrupt configuration

2020-09-09 Thread Bartosz Golaszewski
On Thu, Sep 3, 2020 at 9:30 AM wrote: > > From: dillon min > > The offset of regmap is incorrect, j * 8 is move to the > wrong register. > > for example: > > asume i = 0, j = 1. we want to set KPY5 as interrupt > falling edge mode, regmap[0][1] should be TC3589x_GPIOIBE1 0xcd > but, regmap[i] + j

[PATCH: V2 1/2] gpio: tc35894: fix up tc35894 interrupt configuration

2020-09-03 Thread dillon . minfei
From: dillon min The offset of regmap is incorrect, j * 8 is move to the wrong register. for example: asume i = 0, j = 1. we want to set KPY5 as interrupt falling edge mode, regmap[0][1] should be TC3589x_GPIOIBE1 0xcd but, regmap[i] + j * 8 = TC3589x_GPIOIBE0 + 8 ,point to 0xd4, this is TC3589