Re: [PATCH?] reiserfs: prevent panic: don't allow %-char in journal dev. name

2018-04-09 Thread Jan Kara
On Mon 09-04-18 16:25:17, Jan Kara wrote: > On Wed 04-04-18 21:48:53, Jeff Mahoney wrote: > > On 4/4/18 9:45 PM, Andrew Morton wrote: > > > On Wed, 4 Apr 2018 18:25:16 -0700 Randy Dunlap > > > wrote: > > > > > >> From: Randy Dunlap > > >> > > >> If the reiserfs mount option's journal name conta

Re: [PATCH?] reiserfs: prevent panic: don't allow %-char in journal dev. name

2018-04-09 Thread Dmitry Vyukov
On Mon, Apr 9, 2018 at 4:25 PM, Jan Kara wrote: > On Wed 04-04-18 21:48:53, Jeff Mahoney wrote: >> On 4/4/18 9:45 PM, Andrew Morton wrote: >> > On Wed, 4 Apr 2018 18:25:16 -0700 Randy Dunlap >> > wrote: >> > >> >> From: Randy Dunlap >> >> >> >> If the reiserfs mount option's journal name contai

Re: [PATCH?] reiserfs: prevent panic: don't allow %-char in journal dev. name

2018-04-09 Thread Jan Kara
On Wed 04-04-18 21:48:53, Jeff Mahoney wrote: > On 4/4/18 9:45 PM, Andrew Morton wrote: > > On Wed, 4 Apr 2018 18:25:16 -0700 Randy Dunlap > > wrote: > > > >> From: Randy Dunlap > >> > >> If the reiserfs mount option's journal name contains a '%' character, > >> it can lead to a WARN_ONCE() in

Re: [PATCH?] reiserfs: prevent panic: don't allow %-char in journal dev. name

2018-04-06 Thread Jeff Mahoney
On 4/5/18 5:04 AM, Rasmus Villemoes wrote: > On 2018-04-05 03:45, Andrew Morton wrote: >> On Wed, 4 Apr 2018 18:25:16 -0700 Randy Dunlap wrote: >> >>> From: Randy Dunlap >>> >>> If the reiserfs mount option's journal name contains a '%' character, >>> it can lead to a WARN_ONCE() in lib/vsprintf.

Re: [PATCH?] reiserfs: prevent panic: don't allow %-char in journal dev. name

2018-04-06 Thread Rasmus Villemoes
On 2018-04-05 11:04, Rasmus Villemoes wrote: > On 2018-04-05 03:45, Andrew Morton wrote: >> >> Isn't the bug in journal_init_dev()? > > Urgh. At first I was about to reply that the real bug was in reiserfs.h > for failing to annotate __reiserfs_warning with __printf(). But digging > into it, it tu

Re: [PATCH?] reiserfs: prevent panic: don't allow %-char in journal dev. name

2018-04-05 Thread Rasmus Villemoes
On 2018-04-05 03:45, Andrew Morton wrote: > On Wed, 4 Apr 2018 18:25:16 -0700 Randy Dunlap wrote: > >> From: Randy Dunlap >> >> If the reiserfs mount option's journal name contains a '%' character, >> it can lead to a WARN_ONCE() in lib/vsprintf.c::format_decode(), >> saying: "Please remove unsu

Re: [PATCH?] reiserfs: prevent panic: don't allow %-char in journal dev. name

2018-04-04 Thread Randy Dunlap
On 04/04/2018 06:48 PM, Jeff Mahoney wrote: > On 4/4/18 9:45 PM, Andrew Morton wrote: >> On Wed, 4 Apr 2018 18:25:16 -0700 Randy Dunlap wrote: >> >>> From: Randy Dunlap >>> >>> If the reiserfs mount option's journal name contains a '%' character, >>> it can lead to a WARN_ONCE() in lib/vsprintf.c

Re: [PATCH?] reiserfs: prevent panic: don't allow %-char in journal dev. name

2018-04-04 Thread Jeff Mahoney
On 4/4/18 9:45 PM, Andrew Morton wrote: > On Wed, 4 Apr 2018 18:25:16 -0700 Randy Dunlap wrote: > >> From: Randy Dunlap >> >> If the reiserfs mount option's journal name contains a '%' character, >> it can lead to a WARN_ONCE() in lib/vsprintf.c::format_decode(), >> saying: "Please remove unsupp

Re: [PATCH?] reiserfs: prevent panic: don't allow %-char in journal dev. name

2018-04-04 Thread Andrew Morton
On Wed, 4 Apr 2018 18:25:16 -0700 Randy Dunlap wrote: > From: Randy Dunlap > > If the reiserfs mount option's journal name contains a '%' character, > it can lead to a WARN_ONCE() in lib/vsprintf.c::format_decode(), > saying: "Please remove unsupported %/ in format string." > That's OK until pa

[PATCH?] reiserfs: prevent panic: don't allow %-char in journal dev. name

2018-04-04 Thread Randy Dunlap
From: Randy Dunlap If the reiserfs mount option's journal name contains a '%' character, it can lead to a WARN_ONCE() in lib/vsprintf.c::format_decode(), saying: "Please remove unsupported %/ in format string." That's OK until panic_on_warn is set, at which point it's dead, Jim. To placate this