Re: [PATCH? 3/3] move daemonized kernel threads into the swapper's session

2007-11-26 Thread Eric W. Biederman
[EMAIL PROTECTED] (Eric W. Biederman) writes: > Hmm. I wonder if we could ensure kernel_thread always > returns a global pid_t, and then reallocate the struct > pid for the task we have just daemonized so that it only > has a single pid in the init_pid_ns. Well we can't reallocate the struct

Re: [PATCH? 3/3] move daemonized kernel threads into the swapper's session

2007-11-26 Thread Eric W. Biederman
Oleg Nesterov <[EMAIL PROTECTED]> writes: > Any reason why daemonized kthread still uses 1,1 special pids? This patch > sets 0,0 pids, this matches kthread_create'ed threads. You got it in your reply... > Signed-off-by: Oleg Nesterov <[EMAIL PROTECTED]> Acked-by: "Eric W. Biederman" <[EMAIL

Re: [PATCH? 3/3] move daemonized kernel threads into the swapper's session

2007-11-26 Thread Oleg Nesterov
On 11/26, Oleg Nesterov wrote: > > Any reason why daemonized kthread still uses 1,1 special pids? Actually, I guess the reason is that this was not possible before. Now that set_special_pids uses "struct pid" we can do this. Perhaps it is better to move the callsite to reparent_to_kthreadd() and

[PATCH? 3/3] move daemonized kernel threads into the swapper's session

2007-11-26 Thread Oleg Nesterov
Any reason why daemonized kthread still uses 1,1 special pids? This patch sets 0,0 pids, this matches kthread_create'ed threads. Signed-off-by: Oleg Nesterov <[EMAIL PROTECTED]> --- PT/kernel/exit.c~3_daemonize_swapper2007-11-26 16:47:35.0 +0300 +++ PT/kernel/exit.c

[PATCH? 3/3] move daemonized kernel threads into the swapper's session

2007-11-26 Thread Oleg Nesterov
Any reason why daemonized kthread still uses 1,1 special pids? This patch sets 0,0 pids, this matches kthread_create'ed threads. Signed-off-by: Oleg Nesterov [EMAIL PROTECTED] --- PT/kernel/exit.c~3_daemonize_swapper2007-11-26 16:47:35.0 +0300 +++ PT/kernel/exit.c2007-11-26

Re: [PATCH? 3/3] move daemonized kernel threads into the swapper's session

2007-11-26 Thread Oleg Nesterov
On 11/26, Oleg Nesterov wrote: Any reason why daemonized kthread still uses 1,1 special pids? Actually, I guess the reason is that this was not possible before. Now that set_special_pids uses struct pid we can do this. Perhaps it is better to move the callsite to reparent_to_kthreadd() and

Re: [PATCH? 3/3] move daemonized kernel threads into the swapper's session

2007-11-26 Thread Eric W. Biederman
Oleg Nesterov [EMAIL PROTECTED] writes: Any reason why daemonized kthread still uses 1,1 special pids? This patch sets 0,0 pids, this matches kthread_create'ed threads. You got it in your reply... Signed-off-by: Oleg Nesterov [EMAIL PROTECTED] Acked-by: Eric W. Biederman [EMAIL PROTECTED]

Re: [PATCH? 3/3] move daemonized kernel threads into the swapper's session

2007-11-26 Thread Eric W. Biederman
[EMAIL PROTECTED] (Eric W. Biederman) writes: Hmm. I wonder if we could ensure kernel_thread always returns a global pid_t, and then reallocate the struct pid for the task we have just daemonized so that it only has a single pid in the init_pid_ns. Well we can't reallocate the struct pid,