Re: [PATCH]: Fix old SCSI adapter crashes with CD-ROM (take 2)

2007-05-08 Thread James Bottomley
On Tue, 2007-05-08 at 18:53 +0100, Alan Cox wrote: > > The ultimate goal is to be able to eliminate the unchecked_isa_dma flag > > entirely and have the block layer (or device mask allocations) fix all > > of this in every ULD. > > About time ;) Actually, I should point out (before those who did

Re: [PATCH]: Fix old SCSI adapter crashes with CD-ROM (take 2)

2007-05-08 Thread Alan Cox
> > Long answer - it doesn't take this path. > > > > Different bug, both want fixing I suspect. > > Actually, it does take this path ... one of the things we've been doing > in SCSI is slowly eliminating the old direct submission paths in favour > of sending everything through the correct block l

Re: [PATCH]: Fix old SCSI adapter crashes with CD-ROM (take 2)

2007-05-08 Thread James Bottomley
On Tue, 2007-05-08 at 18:42 +0100, Alan Cox wrote: > > Mike Christie tells me we're missing bouncing by accident in the > > scsi_execute path (but not the scsi_execute_async path). He says this > > is the fix he proposed: > > > > http://marc.info/?l=linux-scsi&m=115981479822790&w=2 > > > > Can w

Re: [PATCH]: Fix old SCSI adapter crashes with CD-ROM (take 2)

2007-05-08 Thread Alan Cox
> Mike Christie tells me we're missing bouncing by accident in the > scsi_execute path (but not the scsi_execute_async path). He says this > is the fix he proposed: > > http://marc.info/?l=linux-scsi&m=115981479822790&w=2 > > Can we just merge this instead? Short answer: No Long answer - it do

Re: [PATCH]: Fix old SCSI adapter crashes with CD-ROM (take 2)

2007-05-08 Thread Jens Axboe
On Tue, May 08 2007, James Bottomley wrote: > On Tue, 2007-05-08 at 18:40 +0200, Jens Axboe wrote: > > On Tue, May 08 2007, James Bottomley wrote: > > > On Tue, 2007-05-08 at 18:14 +0200, Jens Axboe wrote: > > > > On Tue, May 08 2007, Alan Cox wrote: > > > > > The CD-ROM layer doesn't bounce reques

Re: [PATCH]: Fix old SCSI adapter crashes with CD-ROM (take 2)

2007-05-08 Thread Jens Axboe
On Tue, May 08 2007, Mike Christie wrote: > James Bottomley wrote: > > On Tue, 2007-05-08 at 18:14 +0200, Jens Axboe wrote: > >> On Tue, May 08 2007, Alan Cox wrote: > >>> The CD-ROM layer doesn't bounce requests for old ISA controllers (and > >>> nor should it). However they get injected into the

Re: [PATCH]: Fix old SCSI adapter crashes with CD-ROM (take 2)

2007-05-08 Thread James Bottomley
On Tue, 2007-05-08 at 18:40 +0200, Jens Axboe wrote: > On Tue, May 08 2007, James Bottomley wrote: > > On Tue, 2007-05-08 at 18:14 +0200, Jens Axboe wrote: > > > On Tue, May 08 2007, Alan Cox wrote: > > > > The CD-ROM layer doesn't bounce requests for old ISA controllers (and > > > > nor should it)

Re: [PATCH]: Fix old SCSI adapter crashes with CD-ROM (take 2)

2007-05-08 Thread Mike Christie
James Bottomley wrote: > On Tue, 2007-05-08 at 18:14 +0200, Jens Axboe wrote: >> On Tue, May 08 2007, Alan Cox wrote: >>> The CD-ROM layer doesn't bounce requests for old ISA controllers (and >>> nor should it). However they get injected into the SCSI layer via >>> sr_ioctl which also doesn't bounc

Re: [PATCH]: Fix old SCSI adapter crashes with CD-ROM (take 2)

2007-05-08 Thread Jens Axboe
On Tue, May 08 2007, James Bottomley wrote: > On Tue, 2007-05-08 at 18:14 +0200, Jens Axboe wrote: > > On Tue, May 08 2007, Alan Cox wrote: > > > The CD-ROM layer doesn't bounce requests for old ISA controllers (and > > > nor should it). However they get injected into the SCSI layer via > > > sr_io

Re: [PATCH]: Fix old SCSI adapter crashes with CD-ROM (take 2)

2007-05-08 Thread James Bottomley
On Tue, 2007-05-08 at 18:14 +0200, Jens Axboe wrote: > On Tue, May 08 2007, Alan Cox wrote: > > The CD-ROM layer doesn't bounce requests for old ISA controllers (and > > nor should it). However they get injected into the SCSI layer via > > sr_ioctl which also doesn't bounce them and SCSI then passe

Re: [PATCH]: Fix old SCSI adapter crashes with CD-ROM (take 2)

2007-05-08 Thread Jens Axboe
On Tue, May 08 2007, Alan Cox wrote: > The CD-ROM layer doesn't bounce requests for old ISA controllers (and > nor should it). However they get injected into the SCSI layer via > sr_ioctl which also doesn't bounce them and SCSI then passes the buffer > along to a device with unchecked_isa_dma set w

[PATCH]: Fix old SCSI adapter crashes with CD-ROM (take 2)

2007-05-08 Thread Alan Cox
The CD-ROM layer doesn't bounce requests for old ISA controllers (and nor should it). However they get injected into the SCSI layer via sr_ioctl which also doesn't bounce them and SCSI then passes the buffer along to a device with unchecked_isa_dma set which either panics or truncates the buffer to