Re: [PATCH]: check_region cleanup in sbpcd.c

On 12/06/07, Surya <[EMAIL PROTECTED]> wrote: [snip] > I am sending with all the corrections, if its ok to acknowledge it? Looks good to me. Signed-off-by: Surya Prabhakar <[EMAIL PROTECTED]> Reviewed-by: Jesper Juhl <[EMAIL PROTECTED]> -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post

Re: [PATCH]: check_region cleanup in sbpcd.c

On 12/06/07, Surya [EMAIL PROTECTED] wrote: [snip] I am sending with all the corrections, if its ok to acknowledge it? Looks good to me. Signed-off-by: Surya Prabhakar [EMAIL PROTECTED] Reviewed-by: Jesper Juhl [EMAIL PROTECTED] -- Jesper Juhl [EMAIL PROTECTED] Don't top-post

[PATCH]: check_region cleanup in sbpcd.c

> > + * > > + * > > Why two blank comment lines? Isn't one enough? cleaned it up. > > sti(); > Just in case you are bored, at some point those cli()/sti() need to go > away as well and be replaced with proper locking. But that's a > different patch :-) sure will take it up in the next patch. >

[PATCH]: check_region cleanup in sbpcd.c

+ * + * Why two blank comment lines? Isn't one enough? cleaned it up. sti(); Just in case you are bored, at some point those cli()/sti() need to go away as well and be replaced with proper locking. But that's a different patch :-) sure will take it up in the next patch. Kindly