Re: [PATCH]: complete cleanup of check_region

2007-06-11 Thread Jesper Juhl
On 08/06/07, Surya <[EMAIL PROTECTED]> wrote: > > msg(DBG_INI,"check_drives done.\n"); > > + if(request_region_flag==0) > > + release_region(addr[1],4); > > I know the driver in its current version just tests if the region is > available and do

Re: [PATCH]: complete cleanup of check_region]

2007-06-07 Thread Surya
re-sending with a minor correction... > > > > @@ -5640,6 +5645,7 @@ int __init sbpcd_init(void) > > int i=0, j=0; > > int addr[2]={1, CDROM_PORT}; > > int port_index; > > + int request_region_flag; > > > One could argue that it would be possible to just use the 'j' v

Re: [PATCH]: complete cleanup of check_region

2007-06-07 Thread Surya
> > > > @@ -5640,6 +5645,7 @@ int __init sbpcd_init(void) > > int i=0, j=0; > > int addr[2]={1, CDROM_PORT}; > > int port_index; > > + int request_region_flag; > > > One could argue that it would be possible to just use the 'j' variable > for this since it's not used

Re: [PATCH]: complete cleanup of check_region

2007-06-07 Thread Eberhard Moenkeberg
Hi, On Thu, 7 Jun 2007, Jesper Juhl wrote: > On 07/06/07, Eberhard Moenkeberg <[EMAIL PROTECTED]> wrote: > > On Thu, 7 Jun 2007, Surya wrote: > > > Hi all, > > > This patch cleans up all the instances of check_region and > > > __check_region and replaces them with request_region and > > > _

Re: [PATCH]: complete cleanup of check_region

2007-06-07 Thread Jesper Juhl
On 07/06/07, Eberhard Moenkeberg <[EMAIL PROTECTED]> wrote: Hi, On Thu, 7 Jun 2007, Surya wrote: > > Hi all, > This patch cleans up all the instances of check_region and > __check_region and replaces them with request_region and > __request_region. Applies and compiles clean on latest Lin

Re: [PATCH]: complete cleanup of check_region

2007-06-07 Thread Eberhard Moenkeberg
Hi, On Thu, 7 Jun 2007, Surya wrote: > > Hi all, > This patch cleans up all the instances of check_region and > __check_region and replaces them with request_region and > __request_region. Applies and compiles clean on latest Linus tree. > > Files affected: > drivers/cdrom/sbpcd.c >

Re: [PATCH]: complete cleanup of check_region

2007-06-07 Thread Jesper Juhl
On 07/06/07, Surya <[EMAIL PROTECTED]> wrote: Hi all, This patch cleans up all the instances of check_region and __check_region and replaces them with request_region and __request_region. Applies and compiles clean on latest Linus tree. Files affected: drivers/cdrom/sbpcd.c

[PATCH]: complete cleanup of check_region

2007-06-07 Thread Surya
Hi all, This patch cleans up all the instances of check_region and __check_region and replaces them with request_region and __request_region. Applies and compiles clean on latest Linus tree. Files affected: drivers/cdrom/sbpcd.c drivers/pnp/resource.c include/linux/