Re: [PATCH][5/5] floppy.c: Fix device_create_file() warning

2007-02-06 Thread Gene Heskett
On Tuesday 06 February 2007 01:32, H. Peter Anvin wrote: >Gene Heskett wrote: >> On Monday 05 February 2007 18:30, Jesper Juhl wrote: >> >> And this is almost OT for this, but I'd like to interject here that in >> recent history, it has been very very difficult to properly access >> LSN0 of a

Re: [PATCH][5/5] floppy.c: Fix device_create_file() warning

2007-02-06 Thread Gene Heskett
On Tuesday 06 February 2007 01:32, H. Peter Anvin wrote: Gene Heskett wrote: On Monday 05 February 2007 18:30, Jesper Juhl wrote: And this is almost OT for this, but I'd like to interject here that in recent history, it has been very very difficult to properly access LSN0 of a floppy. Some

Re: [PATCH][5/5] floppy.c: Fix device_create_file() warning

2007-02-05 Thread H. Peter Anvin
Gene Heskett wrote: On Monday 05 February 2007 18:30, Jesper Juhl wrote: And this is almost OT for this, but I'd like to interject here that in recent history, it has been very very difficult to properly access LSN0 of a floppy. Some formats, such as those laid down by a WD-1773 floppy

Re: [PATCH][5/5] floppy.c: Fix device_create_file() warning

2007-02-05 Thread Gene Heskett
On Monday 05 February 2007 18:30, Jesper Juhl wrote: And this is almost OT for this, but I'd like to interject here that in recent history, it has been very very difficult to properly access LSN0 of a floppy. Some formats, such as those laid down by a WD-1773 floppy controller, do indeed use

[PATCH][5/5] floppy.c: Fix device_create_file() warning

2007-02-05 Thread Jesper Juhl
This fixes the warning warning: ignoring return value of `device_create_file', declared with attribute warn_unused_result in function `floppy_init'. It does this by checking the return value and printing a warning message in case of no success. Signed-off-by: Jesper Juhl <[EMAIL

[PATCH][5/5] floppy.c: Fix device_create_file() warning

2007-02-05 Thread Jesper Juhl
This fixes the warning warning: ignoring return value of `device_create_file', declared with attribute warn_unused_result in function `floppy_init'. It does this by checking the return value and printing a warning message in case of no success. Signed-off-by: Jesper Juhl [EMAIL PROTECTED]

Re: [PATCH][5/5] floppy.c: Fix device_create_file() warning

2007-02-05 Thread Gene Heskett
On Monday 05 February 2007 18:30, Jesper Juhl wrote: And this is almost OT for this, but I'd like to interject here that in recent history, it has been very very difficult to properly access LSN0 of a floppy. Some formats, such as those laid down by a WD-1773 floppy controller, do indeed use

Re: [PATCH][5/5] floppy.c: Fix device_create_file() warning

2007-02-05 Thread H. Peter Anvin
Gene Heskett wrote: On Monday 05 February 2007 18:30, Jesper Juhl wrote: And this is almost OT for this, but I'd like to interject here that in recent history, it has been very very difficult to properly access LSN0 of a floppy. Some formats, such as those laid down by a WD-1773 floppy