Re: [PATCH][RESEND] Fix a potential NULL pointer deref in the aic7xxx, ahc_print_register() function

2007-08-05 Thread Justin T. Gibbs
All of this logic was simplified back in '05 in the BSD drivers by adding this to the top of the function: u_int dummy_column; if (cur_column == NULL) { dummy_column = 0; cur_column = _column; } and then stripping out the cur_column ==

Re: [PATCH][RESEND] Fix a potential NULL pointer deref in the aic7xxx, ahc_print_register() function

2007-08-05 Thread Jesper Juhl
On Sunday 05 August 2007 17:42:31 Justin T. Gibbs wrote: > All of this logic was simplified back in '05 in the BSD drivers by adding > this to the top of the function: > > u_int dummy_column; > > if (cur_column == NULL) { > dummy_column = 0; >

Re: [PATCH][RESEND] Fix a potential NULL pointer deref in the aic7xxx, ahc_print_register() function

2007-08-05 Thread James Bottomley
On Sun, 2007-08-05 at 17:36 +0200, Jesper Juhl wrote: > On 04/08/07, James Bottomley <[EMAIL PROTECTED]> wrote: > > On Sat, 2007-08-04 at 20:30 +0200, Jesper Juhl wrote: > > > (resend of patch previously submitted on 28-Jul-2007 23:06) > > > > > > > > > Ehlo, > > > > > > The Coverity checker

Re: [PATCH][RESEND] Fix a potential NULL pointer deref in the aic7xxx, ahc_print_register() function

2007-08-05 Thread Jesper Juhl
On 04/08/07, James Bottomley <[EMAIL PROTECTED]> wrote: > On Sat, 2007-08-04 at 20:30 +0200, Jesper Juhl wrote: > > (resend of patch previously submitted on 28-Jul-2007 23:06) > > > > > > Ehlo, > > > > The Coverity checker noticed that we have a potential NULL pointer > > deref in

Re: [PATCH][RESEND] Fix a potential NULL pointer deref in the aic7xxx, ahc_print_register() function

2007-08-05 Thread James Bottomley
On Sun, 2007-08-05 at 17:36 +0200, Jesper Juhl wrote: On 04/08/07, James Bottomley [EMAIL PROTECTED] wrote: On Sat, 2007-08-04 at 20:30 +0200, Jesper Juhl wrote: (resend of patch previously submitted on 28-Jul-2007 23:06) Ehlo, The Coverity checker noticed that we have a

Re: [PATCH][RESEND] Fix a potential NULL pointer deref in the aic7xxx, ahc_print_register() function

2007-08-05 Thread Jesper Juhl
On Sunday 05 August 2007 17:42:31 Justin T. Gibbs wrote: All of this logic was simplified back in '05 in the BSD drivers by adding this to the top of the function: u_int dummy_column; if (cur_column == NULL) { dummy_column = 0;

Re: [PATCH][RESEND] Fix a potential NULL pointer deref in the aic7xxx, ahc_print_register() function

2007-08-05 Thread Jesper Juhl
On 04/08/07, James Bottomley [EMAIL PROTECTED] wrote: On Sat, 2007-08-04 at 20:30 +0200, Jesper Juhl wrote: (resend of patch previously submitted on 28-Jul-2007 23:06) Ehlo, The Coverity checker noticed that we have a potential NULL pointer deref in

Re: [PATCH][RESEND] Fix a potential NULL pointer deref in the aic7xxx, ahc_print_register() function

2007-08-05 Thread Justin T. Gibbs
All of this logic was simplified back in '05 in the BSD drivers by adding this to the top of the function: u_int dummy_column; if (cur_column == NULL) { dummy_column = 0; cur_column = dummy_column; } and then stripping out the cur_column

Re: [PATCH][RESEND] Fix a potential NULL pointer deref in the aic7xxx, ahc_print_register() function

2007-08-04 Thread James Bottomley
On Sat, 2007-08-04 at 20:30 +0200, Jesper Juhl wrote: > (resend of patch previously submitted on 28-Jul-2007 23:06) > > > Ehlo, > > The Coverity checker noticed that we have a potential NULL pointer > deref in drivers/scsi/aic7xxx/aic7xxx_core.c::ahc_print_register(). > This patch handles it

Re: [PATCH][RESEND] Fix a potential NULL pointer deref in the aic7xxx, ahc_print_register() function

2007-08-04 Thread James Bottomley
On Sat, 2007-08-04 at 20:30 +0200, Jesper Juhl wrote: (resend of patch previously submitted on 28-Jul-2007 23:06) Ehlo, The Coverity checker noticed that we have a potential NULL pointer deref in drivers/scsi/aic7xxx/aic7xxx_core.c::ahc_print_register(). This patch handles it by adding