Re: [PATCH][RFC] PCMCIA support for 8xx using platform devices

2007-04-23 Thread Segher Boessenkool
That's a horrible argument. Please do it properly, and let arch/ppc die as it should. We shouldn't be adding anything to it anymore anyway. I understand your point, but we shouldn't trash existing bits either. Why not? The things that haven't been ported over yet obviously are

Re: [PATCH][RFC] PCMCIA support for 8xx using platform devices

2007-04-23 Thread Vitaly Bordug
On Mon, 23 Apr 2007 08:59:57 +0100 Christoph Hellwig wrote: > On Mon, Apr 23, 2007 at 10:14:27AM +0400, Vitaly Bordug wrote: > > On Sun, 22 Apr 2007 23:49:41 +0200 > > Arnd Bergmann wrote: > > > > > On Sunday 22 April 2007, Vitaly Bordug wrote: > > > > This utilizes PCMCIA on mpc885ads and

Re: Fw: [PATCH][RFC] PCMCIA support for 8xx using platform devices

2007-04-23 Thread Scott Wood
On Sun, Apr 22, 2007 at 11:26:58PM +0400, Vitaly Bordug wrote: > diff --git a/arch/powerpc/boot/dts/mpc885ads.dts > b/arch/powerpc/boot/dts/mpc885ads.dts > index 90e047a..330ac91 100644 > --- a/arch/powerpc/boot/dts/mpc885ads.dts > +++ b/arch/powerpc/boot/dts/mpc885ads.dts > @@ -112,6 +112,18 @@

Re: [PATCH][RFC] PCMCIA support for 8xx using platform devices

2007-04-23 Thread Christoph Hellwig
On Mon, Apr 23, 2007 at 10:14:27AM +0400, Vitaly Bordug wrote: > On Sun, 22 Apr 2007 23:49:41 +0200 > Arnd Bergmann wrote: > > > On Sunday 22 April 2007, Vitaly Bordug wrote: > > > This utilizes PCMCIA on mpc885ads and mpc866ads from arch/powerpc. > > > In the new approach, direct IMMR accesses

Re: [PATCH][RFC] PCMCIA support for 8xx using platform devices

2007-04-23 Thread Vitaly Bordug
On Sun, 22 Apr 2007 23:49:41 +0200 Arnd Bergmann wrote: > On Sunday 22 April 2007, Vitaly Bordug wrote: > > This utilizes PCMCIA on mpc885ads and mpc866ads from arch/powerpc. > > In the new approach, direct IMMR accesses from within drivers/ were > > totally eliminated, that requires

Re: [PATCH][RFC] PCMCIA support for 8xx using platform devices

2007-04-23 Thread Vitaly Bordug
On Sun, 22 Apr 2007 23:49:41 +0200 Arnd Bergmann wrote: On Sunday 22 April 2007, Vitaly Bordug wrote: This utilizes PCMCIA on mpc885ads and mpc866ads from arch/powerpc. In the new approach, direct IMMR accesses from within drivers/ were totally eliminated, that requires hardware_enable,

Re: [PATCH][RFC] PCMCIA support for 8xx using platform devices

2007-04-23 Thread Christoph Hellwig
On Mon, Apr 23, 2007 at 10:14:27AM +0400, Vitaly Bordug wrote: On Sun, 22 Apr 2007 23:49:41 +0200 Arnd Bergmann wrote: On Sunday 22 April 2007, Vitaly Bordug wrote: This utilizes PCMCIA on mpc885ads and mpc866ads from arch/powerpc. In the new approach, direct IMMR accesses from within

Re: Fw: [PATCH][RFC] PCMCIA support for 8xx using platform devices

2007-04-23 Thread Scott Wood
On Sun, Apr 22, 2007 at 11:26:58PM +0400, Vitaly Bordug wrote: diff --git a/arch/powerpc/boot/dts/mpc885ads.dts b/arch/powerpc/boot/dts/mpc885ads.dts index 90e047a..330ac91 100644 --- a/arch/powerpc/boot/dts/mpc885ads.dts +++ b/arch/powerpc/boot/dts/mpc885ads.dts @@ -112,6 +112,18 @@

Re: [PATCH][RFC] PCMCIA support for 8xx using platform devices

2007-04-23 Thread Vitaly Bordug
On Mon, 23 Apr 2007 08:59:57 +0100 Christoph Hellwig wrote: On Mon, Apr 23, 2007 at 10:14:27AM +0400, Vitaly Bordug wrote: On Sun, 22 Apr 2007 23:49:41 +0200 Arnd Bergmann wrote: On Sunday 22 April 2007, Vitaly Bordug wrote: This utilizes PCMCIA on mpc885ads and mpc866ads from

Re: [PATCH][RFC] PCMCIA support for 8xx using platform devices

2007-04-23 Thread Segher Boessenkool
That's a horrible argument. Please do it properly, and let arch/ppc die as it should. We shouldn't be adding anything to it anymore anyway. I understand your point, but we shouldn't trash existing bits either. Why not? The things that haven't been ported over yet obviously are

Re: Fw: [PATCH][RFC] PCMCIA support for 8xx using platform devices

2007-04-22 Thread Arnd Bergmann
On Sunday 22 April 2007, Vitaly Bordug wrote: > This utilizes PCMCIA on mpc885ads and mpc866ads from arch/powerpc. In the > new approach, direct IMMR accesses from within drivers/ were totally > eliminated, that requires hardware_enable, hardware_disable, voltage_set > board-specific functions to

Fw: [PATCH][RFC] PCMCIA support for 8xx using platform devices

2007-04-22 Thread Vitaly Bordug
This utilizes PCMCIA on mpc885ads and mpc866ads from arch/powerpc. In the new approach, direct IMMR accesses from within drivers/ were totally eliminated, that requires hardware_enable, hardware_disable, voltage_set board-specific functions to be moved over to BSP code section

Fw: [PATCH][RFC] PCMCIA support for 8xx using platform devices

2007-04-22 Thread Vitaly Bordug
This utilizes PCMCIA on mpc885ads and mpc866ads from arch/powerpc. In the new approach, direct IMMR accesses from within drivers/ were totally eliminated, that requires hardware_enable, hardware_disable, voltage_set board-specific functions to be moved over to BSP code section

Re: Fw: [PATCH][RFC] PCMCIA support for 8xx using platform devices

2007-04-22 Thread Arnd Bergmann
On Sunday 22 April 2007, Vitaly Bordug wrote: This utilizes PCMCIA on mpc885ads and mpc866ads from arch/powerpc. In the new approach, direct IMMR accesses from within drivers/ were totally eliminated, that requires hardware_enable, hardware_disable, voltage_set board-specific functions to be