Re: [PATCH][RFC] unbreak generic futex_atomic_cmpxchg_inatomic() on UP

2007-10-04 Thread Geert Uytterhoeven
On Thu, 4 Oct 2007, Mikael Pettersson wrote: > On Wed, 3 Oct 2007 22:33:46 +0300, Riku Voipio wrote: > > What's the state of this patch? I can confirm tst-robust1 > > from glibc testsuite locks a armv5 machine hard. With this patch > > applied, the test succeeds. > > There were no comments from an

Re: [PATCH][RFC] unbreak generic futex_atomic_cmpxchg_inatomic() on UP

2007-10-04 Thread Mikael Pettersson
On Wed, 3 Oct 2007 22:33:46 +0300, Riku Voipio wrote: > What's the state of this patch? I can confirm tst-robust1 > from glibc testsuite locks a armv5 machine hard. With this patch > applied, the test succeeds. There were no comments from any Linux arch or futex maintainer. Because of that I inten

[PATCH][RFC] unbreak generic futex_atomic_cmpxchg_inatomic() on UP

2007-10-03 Thread Riku Voipio
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 What's the state of this patch? I can confirm tst-robust1 from glibc testsuite locks a armv5 machine hard. With this patch applied, the test succeeds. > The higher-end archs (x86, sparc64, ppc64, etc) provide fully-functional > asm/futex.h implementat

Re: [PATCH][RFC] unbreak generic futex_atomic_cmpxchg_inatomic() on UP

2007-08-01 Thread Lennert Buytenhek
On Thu, Aug 02, 2007 at 02:06:27AM +0200, Mikael Pettersson wrote: > > > @@ -52,7 +53,34 @@ futex_atomic_op_inuser (int encoded_op, > > > static inline int > > > futex_atomic_cmpxchg_inatomic(int __user *uaddr, int oldval, int newval) > > > { > > > +#ifdef CONFIG_SMP > > > return -ENOSYS; >

Re: [PATCH][RFC] unbreak generic futex_atomic_cmpxchg_inatomic() on UP

2007-08-01 Thread Mikael Pettersson
On Thu, 2 Aug 2007 01:49:02 +0200, Lennert Buytenhek wrote: > On Thu, Aug 02, 2007 at 01:00:21AM +0200, Mikael Pettersson wrote: > > > @@ -52,7 +53,34 @@ futex_atomic_op_inuser (int encoded_op, > > static inline int > > futex_atomic_cmpxchg_inatomic(int __user *uaddr, int oldval, int newval) >

Re: [PATCH][RFC] unbreak generic futex_atomic_cmpxchg_inatomic() on UP

2007-08-01 Thread Lennert Buytenhek
On Thu, Aug 02, 2007 at 01:00:21AM +0200, Mikael Pettersson wrote: > @@ -52,7 +53,34 @@ futex_atomic_op_inuser (int encoded_op, > static inline int > futex_atomic_cmpxchg_inatomic(int __user *uaddr, int oldval, int newval) > { > +#ifdef CONFIG_SMP > return -ENOSYS; > +#else Since the ca

[PATCH][RFC] unbreak generic futex_atomic_cmpxchg_inatomic() on UP

2007-08-01 Thread Mikael Pettersson
[Resend. I messed up the To: line the first time] As has been reported recently by Lennert Buytenhek, robust futexes are broken on ARM: >If you're also running into glibc's tst-robust1 test suite test >locking up your ARM machine, you're probably running into the fact >that asm-arm/futex.h includ