Re: [PATCH][RFC v5] timekeeping: Ignore the bogus sleep time if pm_trace is enabled

2016-09-10 Thread Chen Yu
Hi, On Fri, Sep 09, 2016 at 04:33:59PM +0200, Thomas Gleixner wrote: > On Fri, 9 Sep 2016, Chen Yu wrote: > > > +extern void pm_trace_untaint_timekeeping(void); > > And how exactly do you untaint it? Just by clearing the flags. That makes > the RTC time magically correct again? > > > +int arch_pm

Re: [PATCH][RFC v5] timekeeping: Ignore the bogus sleep time if pm_trace is enabled

2016-09-09 Thread Thomas Gleixner
On Fri, 9 Sep 2016, Chen Yu wrote: > > I really have no idea why this is burried in x86 land. The pm_trace hackery > > issues mc146818_set_time() to fiddle with the RTC. So any implementation of > > this is affected. > OK, I've changed this patch according to this suggestion. No you did not! You s

Re: [PATCH][RFC v5] timekeeping: Ignore the bogus sleep time if pm_trace is enabled

2016-09-08 Thread Chen Yu
Hi, On Mon, Sep 05, 2016 at 01:54:20AM -0600, Thomas Gleixner wrote: > On Sun, 4 Sep 2016, Chen Yu wrote: > > Hi Thomas, Rafael, > > On Fri, Sep 02, 2016 at 09:26:51PM +0200, Thomas Gleixner wrote: > > > On Wed, 31 Aug 2016, Rafael J. Wysocki wrote: > > > > On Monday, August 29, 2016 12:40:39 AM Ch

Re: [PATCH][RFC v5] timekeeping: Ignore the bogus sleep time if pm_trace is enabled

2016-09-05 Thread Thomas Gleixner
On Sun, 4 Sep 2016, Chen Yu wrote: > Hi Thomas, Rafael, > On Fri, Sep 02, 2016 at 09:26:51PM +0200, Thomas Gleixner wrote: > > On Wed, 31 Aug 2016, Rafael J. Wysocki wrote: > > > On Monday, August 29, 2016 12:40:39 AM Chen Yu wrote: > > > > + > > > > + /* > > > > +* Make rtc-based per

Re: [PATCH][RFC v5] timekeeping: Ignore the bogus sleep time if pm_trace is enabled

2016-09-04 Thread Chen Yu
Hi Thomas, Rafael, On Fri, Sep 02, 2016 at 09:26:51PM +0200, Thomas Gleixner wrote: > On Wed, 31 Aug 2016, Rafael J. Wysocki wrote: > > On Monday, August 29, 2016 12:40:39 AM Chen Yu wrote: > > > + > > > + /* > > > + * Make rtc-based persistent clock unusable > > > + * if pm_trace is enabled, onl

Re: [PATCH][RFC v5] timekeeping: Ignore the bogus sleep time if pm_trace is enabled

2016-09-02 Thread Thomas Gleixner
On Wed, 31 Aug 2016, Rafael J. Wysocki wrote: > On Monday, August 29, 2016 12:40:39 AM Chen Yu wrote: > > + > > + /* > > +* Make rtc-based persistent clock unusable > > +* if pm_trace is enabled, only take effect > > +* for timekeeping_suspend/resume. > > +*/ > > + if (pm_trace_

Re: [PATCH][RFC v5] timekeeping: Ignore the bogus sleep time if pm_trace is enabled

2016-08-30 Thread Rafael J. Wysocki
On Monday, August 29, 2016 12:40:39 AM Chen Yu wrote: > Previously we encountered some memory overflow issues due to > the bogus sleep time brought by inconsistent rtc, which is > triggered when pm_trace is enabled, and we have fixed it > in recent kernel. However it's improper in the first place >

[PATCH][RFC v5] timekeeping: Ignore the bogus sleep time if pm_trace is enabled

2016-08-28 Thread Chen Yu
Previously we encountered some memory overflow issues due to the bogus sleep time brought by inconsistent rtc, which is triggered when pm_trace is enabled, and we have fixed it in recent kernel. However it's improper in the first place to call __timekeeping_inject_sleeptime() in case that pm_trace