Re: [PATCH][SCSI] scsi-mq: fix requests that use a separate CDB buffer

2014-08-25 Thread Tony Battersby
On 08/23/2014 03:09 PM, Douglas Gilbert wrote: >> For inclusion in 3.17 only. > May want to check if blk-mq work in lk 3.16 and earlier > breaks the bsg driver's capability to send SCSI cdbs > that are longer than 16 bytes. > > I think 3.16 and earlier are OK. The problem was caused by scsi_mq_pr

Re: [PATCH][SCSI] scsi-mq: fix requests that use a separate CDB buffer

2014-08-23 Thread Douglas Gilbert
On 14-08-22 03:53 PM, Tony Battersby wrote: This patch fixes code such as the following with scsi-mq enabled: rq = blk_get_request(...); blk_rq_set_block_pc(rq); rq->cmd = my_cmd_buffer; /* separate CDB buffer */ blk_execute_rq_nowait(...); Code like this appears in e.g. s

Re: [PATCH][SCSI] scsi-mq: fix requests that use a separate CDB buffer

2014-08-22 Thread Douglas Gilbert
On 14-08-22 08:52 PM, Douglas Gilbert wrote: On 14-08-22 03:53 PM, Tony Battersby wrote: This patch fixes code such as the following with scsi-mq enabled: rq = blk_get_request(...); blk_rq_set_block_pc(rq); rq->cmd = my_cmd_buffer; /* separate CDB buffer */ blk_execute_rq_

Re: [PATCH][SCSI] scsi-mq: fix requests that use a separate CDB buffer

2014-08-22 Thread Douglas Gilbert
On 14-08-22 03:53 PM, Tony Battersby wrote: This patch fixes code such as the following with scsi-mq enabled: rq = blk_get_request(...); blk_rq_set_block_pc(rq); rq->cmd = my_cmd_buffer; /* separate CDB buffer */ blk_execute_rq_nowait(...); Code like this appears in e.g. s

[PATCH][SCSI] scsi-mq: fix requests that use a separate CDB buffer

2014-08-22 Thread Tony Battersby
This patch fixes code such as the following with scsi-mq enabled: rq = blk_get_request(...); blk_rq_set_block_pc(rq); rq->cmd = my_cmd_buffer; /* separate CDB buffer */ blk_execute_rq_nowait(...); Code like this appears in e.g. sg_start_req() in drivers/scsi/sg.c (for large CDBs