Re: [PATCH][V2] Smack: fix a dereference before null check on sock->sk

2017-02-09 Thread Colin Ian King
On 09/02/17 18:44, Casey Schaufler wrote: > On 2/9/2017 9:11 AM, Colin King wrote: >> From: Colin Ian King >> >> The initialisation of pointer ssp is from a dereference on sock->sk >> before sock-sk is null checked, hence there is a potential for a >> null pointer deference. Fix this by moving th

Re: [PATCH][V2] Smack: fix a dereference before null check on sock->sk

2017-02-09 Thread Casey Schaufler
On 2/9/2017 9:11 AM, Colin King wrote: > From: Colin Ian King > > The initialisation of pointer ssp is from a dereference on sock->sk > before sock-sk is null checked, hence there is a potential for a > null pointer deference. Fix this by moving the assignment of ssp > to just before it is used i

[PATCH][V2] Smack: fix a dereference before null check on sock->sk

2017-02-09 Thread Colin King
From: Colin Ian King The initialisation of pointer ssp is from a dereference on sock->sk before sock-sk is null checked, hence there is a potential for a null pointer deference. Fix this by moving the assignment of ssp to just before it is used in the call to smk_ipv6_check. Also minor clean up