Re: [PATCH][V2] drivers/usb/serial/mos7840.c: remove unused code

2015-01-19 Thread Johan Hovold
On Mon, Jan 19, 2015 at 01:32:58PM +, Colin King wrote: > From: Colin Ian King > > There is old, unused code that is #defined out by the > use of NOTMOS7840 and NOTMCS7840 - these are not > defined anywhere. > > If NOTMOS7840 is defined then the code will break on null > pointer

[PATCH][V2] drivers/usb/serial/mos7840.c: remove unused code

2015-01-19 Thread Colin King
From: Colin Ian King There is old, unused code that is #defined out by the use of NOTMOS7840 and NOTMCS7840 - these are not defined anywhere. If NOTMOS7840 is defined then the code will break on null pointer dereferences on mos7840_port. So the code is currently unused, and broken anyway, so

[PATCH][V2] drivers/usb/serial/mos7840.c: remove unused code

2015-01-19 Thread Colin King
From: Colin Ian King colin.k...@canonical.com There is old, unused code that is #defined out by the use of NOTMOS7840 and NOTMCS7840 - these are not defined anywhere. If NOTMOS7840 is defined then the code will break on null pointer dereferences on mos7840_port. So the code is currently unused,

Re: [PATCH][V2] drivers/usb/serial/mos7840.c: remove unused code

2015-01-19 Thread Johan Hovold
On Mon, Jan 19, 2015 at 01:32:58PM +, Colin King wrote: From: Colin Ian King colin.k...@canonical.com There is old, unused code that is #defined out by the use of NOTMOS7840 and NOTMCS7840 - these are not defined anywhere. If NOTMOS7840 is defined then the code will break on null