Re: [PATCH][bpf] bpf: verifier: add break statement in switch

2019-06-19 Thread Alexei Starovoitov
On Wed, Jun 19, 2019 at 9:02 AM Gustavo A. R. Silva wrote: > > Notice that in this case, it's much clearer to explicitly add a break > rather than letting the code to fall through. It also avoid potential > future fall-through warnings[1]. > > This patch is part of the ongoing efforts to enable >

Re: [PATCH][bpf] bpf: verifier: add break statement in switch

2019-06-19 Thread Andrii Nakryiko
On Wed, Jun 19, 2019 at 9:02 AM Gustavo A. R. Silva wrote: > > Notice that in this case, it's much clearer to explicitly add a break > rather than letting the code to fall through. It also avoid potential > future fall-through warnings[1]. > > This patch is part of the ongoing efforts to enable >

[PATCH][bpf] bpf: verifier: add break statement in switch

2019-06-19 Thread Gustavo A. R. Silva
Notice that in this case, it's much clearer to explicitly add a break rather than letting the code to fall through. It also avoid potential future fall-through warnings[1]. This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. [1] https://lore.kernel.org/patchwork/patch/1087