Re: [PATCH][bugzilla #8679] therm_throt.c: Fix section mismatch

2007-08-22 Thread Satyam Sharma
On Thu, 23 Aug 2007, Satyam Sharma wrote: > > I must say, this is an amazingly cunning idea. Only things I can think of > against this would be: the dropping of unneeded code is not guaranteed, > but depends on compiler. And we saw from the "static inline {return 0;}" > testcase that gcc can som

Re: [PATCH][bugzilla #8679] therm_throt.c: Fix section mismatch

2007-08-22 Thread Satyam Sharma
On Mon, 20 Aug 2007, Andrew Morton wrote: > On Tue, 21 Aug 2007 10:07:31 +0530 (IST) Satyam Sharma <[EMAIL PROTECTED]> > wrote: > > > > WARNING: arch/i386/kernel/built-in.o(.data+0x2148): Section mismatch: > > reference > > to .init.text: (between 'thermal_throttle_cpu_notifier' and 'mtrr_mut

Re: [PATCH][bugzilla #8679] therm_throt.c: Fix section mismatch

2007-08-20 Thread Andrew Morton
On Mon, 20 Aug 2007 22:03:28 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > register_hotcpu_notifier() is cunning. If CONFIG_HOTPLUG_CPU=y, we need > the notifier block and the function to which it points to be in .data and > in .text. If CONFIG_HOTPLUG_CPU=n, we don't need them to be present

Re: [PATCH][bugzilla #8679] therm_throt.c: Fix section mismatch

2007-08-20 Thread Andrew Morton
On Tue, 21 Aug 2007 10:07:31 +0530 (IST) Satyam Sharma <[EMAIL PROTECTED]> wrote: > > WARNING: arch/i386/kernel/built-in.o(.data+0x2148): Section mismatch: > reference > to .init.text: (between 'thermal_throttle_cpu_notifier' and 'mtrr_mutex') > > comes because struct notifier_block thermal_th

[PATCH][bugzilla #8679] therm_throt.c: Fix section mismatch

2007-08-20 Thread Satyam Sharma
WARNING: arch/i386/kernel/built-in.o(.data+0x2148): Section mismatch: reference to .init.text: (between 'thermal_throttle_cpu_notifier' and 'mtrr_mutex') comes because struct notifier_block thermal_throttle_cpu_notifier in arch/i386/kernel/cpu/mcheck/therm_throt.c goes in .data section but the no