James Bottomley wrote:
> On Mon, 2008-02-04 at 23:36 +0100, Roel Kluin wrote:
>> Note the duplicate test 'SCpnt->sc_data_direction == DMA_FROM_DEVICE'
>> - if (SCpnt->sc_data_direction == DMA_FROM_DEVICE) {
>> + if (SCpnt->sc_data_direction == DMA_TO_DEVICE) {
>>cpp->xdir = DTD_IN;
On Mon, 2008-02-04 at 23:36 +0100, Roel Kluin wrote:
> It should be like this I guess? this patch was not yet tested, please
> confirm.
> --
> Note the duplicate test 'SCpnt->sc_data_direction == DMA_FROM_DEVICE'
>
> from Documentation/DMA-API.txt:
> DMA_TO_DEVICE = PCI_DMA_TODEVICE
On Mon, 2008-02-04 at 23:36 +0100, Roel Kluin wrote:
It should be like this I guess? this patch was not yet tested, please
confirm.
--
Note the duplicate test 'SCpnt-sc_data_direction == DMA_FROM_DEVICE'
from Documentation/DMA-API.txt:
DMA_TO_DEVICE = PCI_DMA_TODEVICE data is
James Bottomley wrote:
On Mon, 2008-02-04 at 23:36 +0100, Roel Kluin wrote:
Note the duplicate test 'SCpnt-sc_data_direction == DMA_FROM_DEVICE'
- if (SCpnt-sc_data_direction == DMA_FROM_DEVICE) {
+ if (SCpnt-sc_data_direction == DMA_TO_DEVICE) {
cpp-xdir = DTD_IN;
[EMAIL PROTECTED] wrote:
> Good to know that somebody still uses the Ultrastor 14f board :).
> Yes, this typo was introduced by somebody doing massive editing to all
> scsi drivers long ago.
> Cheers,
> --db
Actually, I do not own a Ultrastor 14f board. I found this by searching for
if (test)
To: Ballabio, Dario
Cc: [EMAIL PROTECTED]; lkml
Subject: [PATCH][drivers/scsi/u14-34f.c] duplicate test
'SCpnt->sc_data_direction == DMA_FROM_DEVICE'
It should be like this I guess? this patch was not yet tested, please
confirm.
--
Note the duplicate test 'SCpnt->sc_data_direction == DMA_FROM_
To: Ballabio, Dario
Cc: [EMAIL PROTECTED]; lkml
Subject: [PATCH][drivers/scsi/u14-34f.c] duplicate test
'SCpnt-sc_data_direction == DMA_FROM_DEVICE'
It should be like this I guess? this patch was not yet tested, please
confirm.
--
Note the duplicate test 'SCpnt-sc_data_direction == DMA_FROM_DEVICE
[EMAIL PROTECTED] wrote:
Good to know that somebody still uses the Ultrastor 14f board :).
Yes, this typo was introduced by somebody doing massive editing to all
scsi drivers long ago.
Cheers,
--db
Actually, I do not own a Ultrastor 14f board. I found this by searching for
if (test)
...
It should be like this I guess? this patch was not yet tested, please
confirm.
--
Note the duplicate test 'SCpnt->sc_data_direction == DMA_FROM_DEVICE'
from Documentation/DMA-API.txt:
DMA_TO_DEVICE = PCI_DMA_TODEVICE data is going from the
It should be like this I guess? this patch was not yet tested, please
confirm.
--
Note the duplicate test 'SCpnt-sc_data_direction == DMA_FROM_DEVICE'
from Documentation/DMA-API.txt:
DMA_TO_DEVICE = PCI_DMA_TODEVICE data is going from the
10 matches
Mail list logo
