Re: [PATCH][mtd-next] mtd: nand: remove redundant check of len

2017-12-13 Thread Boris Brezillon
On Wed, 13 Dec 2017 20:44:45 + Colin Ian King wrote: > On 13/12/17 20:38, Boris Brezillon wrote: > > On Wed, 13 Dec 2017 20:30:04 + > > Colin Ian King wrote: > > > >> On 13/12/17 20:24, Boris Brezillon wrote: > >>> On Wed, 13 Dec 2017 20:17:43 + > >>> Colin King wrote: > >>>

Re: [PATCH][mtd-next] mtd: nand: remove redundant check of len

2017-12-13 Thread Boris Brezillon
On Wed, 13 Dec 2017 21:38:44 +0100 Boris Brezillon wrote: > On Wed, 13 Dec 2017 20:30:04 + > Colin Ian King wrote: > > > On 13/12/17 20:24, Boris Brezillon wrote: > > > On Wed, 13 Dec 2017 20:17:43 + > > > Colin King wrote: > > > > > >> From: Colin Ian King > > >> > > >> The ch

Re: [PATCH][mtd-next] mtd: nand: remove redundant check of len

2017-12-13 Thread Colin Ian King
On 13/12/17 20:38, Boris Brezillon wrote: > On Wed, 13 Dec 2017 20:30:04 + > Colin Ian King wrote: > >> On 13/12/17 20:24, Boris Brezillon wrote: >>> On Wed, 13 Dec 2017 20:17:43 + >>> Colin King wrote: >>> From: Colin Ian King The check of len being zero is redundant

Re: [PATCH][mtd-next] mtd: nand: remove redundant check of len

2017-12-13 Thread Boris Brezillon
On Wed, 13 Dec 2017 20:30:04 + Colin Ian King wrote: > On 13/12/17 20:24, Boris Brezillon wrote: > > On Wed, 13 Dec 2017 20:17:43 + > > Colin King wrote: > > > >> From: Colin Ian King > >> > >> The check of len being zero is redundant as it has already been > >> sanity checked for th

Re: [PATCH][mtd-next] mtd: nand: remove redundant check of len

2017-12-13 Thread Colin Ian King
On 13/12/17 20:24, Boris Brezillon wrote: > On Wed, 13 Dec 2017 20:17:43 + > Colin King wrote: > >> From: Colin Ian King >> >> The check of len being zero is redundant as it has already been >> sanity checked for this value at the start of the function. Hence >> it is impossible for this tes

Re: [PATCH][mtd-next] mtd: nand: remove redundant check of len

2017-12-13 Thread Boris Brezillon
On Wed, 13 Dec 2017 20:17:43 + Colin King wrote: > From: Colin Ian King > > The check of len being zero is redundant as it has already been > sanity checked for this value at the start of the function. Hence > it is impossible for this test to be true and so the redundant > code can be remo

[PATCH][mtd-next] mtd: nand: remove redundant check of len

2017-12-13 Thread Colin King
From: Colin Ian King The check of len being zero is redundant as it has already been sanity checked for this value at the start of the function. Hence it is impossible for this test to be true and so the redundant code can be removed. Detected by CoverityScan, CID#1462748 ("Logically dead code")