Re: [PATCH][net-next] net: hinic: make functions set_ctrl0 and set_ctrl1 static

From: Colin King Date: Wed, 23 Aug 2017 10:59:40 +0100 > From: Colin Ian King > > The functions set_ctrl0 and set_ctrl1 are local to the source and do > not need to be in global scope, so make them static. > > Cleans up sparse warnings: >

Re: [PATCH][net-next] net: hinic: make functions set_ctrl0 and set_ctrl1 static

From: Colin King Date: Wed, 23 Aug 2017 10:59:40 +0100 > From: Colin Ian King > > The functions set_ctrl0 and set_ctrl1 are local to the source and do > not need to be in global scope, so make them static. > > Cleans up sparse warnings: > symbol 'set_ctrl0' was not declared. Should it be

Re: [PATCH][net-next] net: hinic: make functions set_ctrl0 and set_ctrl1 static

From: "Aviad Krawczyk (A)" Date: Wed, 23 Aug 2017 10:08:58 + > Thanks Please do not top-post. Especially quoting the original message in the way that you did. As a result of how you replied to this, this patch will show up twice in my patchwork queue making more

Re: [PATCH][net-next] net: hinic: make functions set_ctrl0 and set_ctrl1 static

From: "Aviad Krawczyk (A)" Date: Wed, 23 Aug 2017 10:08:58 + > Thanks Please do not top-post. Especially quoting the original message in the way that you did. As a result of how you replied to this, this patch will show up twice in my patchwork queue making more administrative work for

RE: [PATCH][net-next] net: hinic: make functions set_ctrl0 and set_ctrl1 static

Thanks -Original Message- From: Colin King [mailto:colin.k...@canonical.com] Sent: Wednesday, August 23, 2017 1:00 PM To: Aviad Krawczyk (A); net...@vger.kernel.org Cc: kernel-janit...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: [PATCH][net-next] net: hinic: make functions

RE: [PATCH][net-next] net: hinic: make functions set_ctrl0 and set_ctrl1 static

Thanks -Original Message- From: Colin King [mailto:colin.k...@canonical.com] Sent: Wednesday, August 23, 2017 1:00 PM To: Aviad Krawczyk (A); net...@vger.kernel.org Cc: kernel-janit...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: [PATCH][net-next] net: hinic: make functions

[PATCH][net-next] net: hinic: make functions set_ctrl0 and set_ctrl1 static

From: Colin Ian King The functions set_ctrl0 and set_ctrl1 are local to the source and do not need to be in global scope, so make them static. Cleans up sparse warnings: symbol 'set_ctrl0' was not declared. Should it be static? symbol 'set_ctrl1' was not declared.

[PATCH][net-next] net: hinic: make functions set_ctrl0 and set_ctrl1 static

From: Colin Ian King The functions set_ctrl0 and set_ctrl1 are local to the source and do not need to be in global scope, so make them static. Cleans up sparse warnings: symbol 'set_ctrl0' was not declared. Should it be static? symbol 'set_ctrl1' was not declared. Should it be static?