Re: [PATCH][net-next] nexthop: fix incorrect allocation failure on nhg->spare

2020-05-29 Thread David Miller
From: Colin King Date: Thu, 28 May 2020 15:51:14 +0100 > @@ -1185,7 +1185,7 @@ static struct nexthop *nexthop_create_group(struct net > *net, > > /* spare group used for removals */ > nhg->spare = nexthop_grp_alloc(num_nh); I don't even see this line in the current net-next tree n

Re: [PATCH][net-next] nexthop: fix incorrect allocation failure on nhg->spare

2020-05-28 Thread Colin Ian King
On 28/05/2020 16:55, Nikolay Aleksandrov wrote: > On 28/05/2020 18:53, Colin Ian King wrote: >> On 28/05/2020 15:55, Nikolay Aleksandrov wrote: >>> On 28/05/2020 17:53, Nikolay Aleksandrov wrote: On 28/05/2020 17:51, Colin King wrote: > From: Colin Ian King > > The allocation fail

Re: [PATCH][net-next] nexthop: fix incorrect allocation failure on nhg->spare

2020-05-28 Thread Nikolay Aleksandrov
On 28/05/2020 18:53, Colin Ian King wrote: > On 28/05/2020 15:55, Nikolay Aleksandrov wrote: >> On 28/05/2020 17:53, Nikolay Aleksandrov wrote: >>> On 28/05/2020 17:51, Colin King wrote: From: Colin Ian King The allocation failure check for nhg->spare is currently checking the

Re: [PATCH][net-next] nexthop: fix incorrect allocation failure on nhg->spare

2020-05-28 Thread Colin Ian King
On 28/05/2020 15:55, Nikolay Aleksandrov wrote: > On 28/05/2020 17:53, Nikolay Aleksandrov wrote: >> On 28/05/2020 17:51, Colin King wrote: >>> From: Colin Ian King >>> >>> The allocation failure check for nhg->spare is currently checking >>> the pointer nhg rather than nhg->spare which is never f

Re: [PATCH][net-next] nexthop: fix incorrect allocation failure on nhg->spare

2020-05-28 Thread Nikolay Aleksandrov
On 28/05/2020 17:53, Nikolay Aleksandrov wrote: > On 28/05/2020 17:51, Colin King wrote: >> From: Colin Ian King >> >> The allocation failure check for nhg->spare is currently checking >> the pointer nhg rather than nhg->spare which is never false. Fix >> this by checking nhg->spare instead. >> >>

Re: [PATCH][net-next] nexthop: fix incorrect allocation failure on nhg->spare

2020-05-28 Thread David Ahern
On 5/28/20 8:53 AM, Nikolay Aleksandrov wrote: > On 28/05/2020 17:51, Colin King wrote: >> From: Colin Ian King >> >> The allocation failure check for nhg->spare is currently checking >> the pointer nhg rather than nhg->spare which is never false. Fix >> this by checking nhg->spare instead. >> >>

Re: [PATCH][net-next] nexthop: fix incorrect allocation failure on nhg->spare

2020-05-28 Thread Nikolay Aleksandrov
On 28/05/2020 17:51, Colin King wrote: > From: Colin Ian King > > The allocation failure check for nhg->spare is currently checking > the pointer nhg rather than nhg->spare which is never false. Fix > this by checking nhg->spare instead. > > Addresses-Coverity: ("Logically dead code") > Fixes: 4

[PATCH][net-next] nexthop: fix incorrect allocation failure on nhg->spare

2020-05-28 Thread Colin King
From: Colin Ian King The allocation failure check for nhg->spare is currently checking the pointer nhg rather than nhg->spare which is never false. Fix this by checking nhg->spare instead. Addresses-Coverity: ("Logically dead code") Fixes: 430a049190de ("nexthop: Add support for nexthop groups")