Re: [PATCH][next] RDMA/nes: remove redundant check on udata

2019-03-26 Thread Jason Gunthorpe
On Sat, Mar 02, 2019 at 11:06:36PM +, Colin King wrote: > From: Colin Ian King > > The non-null check on udata is redundant as this check was performed > just a few statements earlier and the check is always true as udata > must be non-null at this point. Remove redundant the check on udata >

Re: [PATCH][next] RDMA/nes: remove redundant check on udata

2019-03-07 Thread Leon Romanovsky
On Thu, Mar 07, 2019 at 10:23:28AM +, Colin Ian King wrote: > On 04/03/2019 06:36, Leon Romanovsky wrote: > > On Sat, Mar 02, 2019 at 11:06:36PM +, Colin King wrote: > >> From: Colin Ian King > >> > >> The non-null check on udata is redundant as this check was performed > >> just a few sta

Re: [PATCH][next] RDMA/nes: remove redundant check on udata

2019-03-07 Thread Colin Ian King
On 04/03/2019 06:36, Leon Romanovsky wrote: > On Sat, Mar 02, 2019 at 11:06:36PM +, Colin King wrote: >> From: Colin Ian King >> >> The non-null check on udata is redundant as this check was performed >> just a few statements earlier and the check is always true as udata >> must be non-null at

Re: [PATCH][next] RDMA/nes: remove redundant check on udata

2019-03-03 Thread Leon Romanovsky
On Sat, Mar 02, 2019 at 11:06:36PM +, Colin King wrote: > From: Colin Ian King > > The non-null check on udata is redundant as this check was performed > just a few statements earlier and the check is always true as udata > must be non-null at this point. Remove redundant the check on udata >

[PATCH][next] RDMA/nes: remove redundant check on udata

2019-03-02 Thread Colin King
From: Colin Ian King The non-null check on udata is redundant as this check was performed just a few statements earlier and the check is always true as udata must be non-null at this point. Remove redundant the check on udata and the redundant else part that can never be executed. Detected by Co