Re: [PATCH][next] UAPI: nfsfh.h: Replace one-element array with flexible-array member

2021-03-29 Thread Gustavo A. R. Silva
On 3/29/21 09:57, Chuck Lever wrote: > Sorry for the reply via gmail, the original patch did not show up in > my Oracle mailbox. > > I've been waiting for a resolution of this thread (and perhaps a > Reviewed-by). But in > the meantime I've committed this, provisionally, to the for-next topic b

Re: [PATCH][next] UAPI: nfsfh.h: Replace one-element array with flexible-array member

2021-03-29 Thread Chuck Lever
Sorry for the reply via gmail, the original patch did not show up in my Oracle mailbox. I've been waiting for a resolution of this thread (and perhaps a Reviewed-by). But in the meantime I've committed this, provisionally, to the for-next topic branch in git://git.kernel.org/pub/scm/linux/kernel/

Re: [PATCH][next] UAPI: nfsfh.h: Replace one-element array with flexible-array member

2021-03-26 Thread Gustavo A. R. Silva
On 3/26/21 03:17, David Laight wrote: > From: Gustavo A. R. Silva >> Sent: 25 March 2021 21:12 >> >> On 3/25/21 10:29, David Laight wrote: >> > > Could you use the simpler: >> struct nfs_fhbase_new { >> __u8 fb_version; >> __u8 fb_auth_type;

RE: [PATCH][next] UAPI: nfsfh.h: Replace one-element array with flexible-array member

2021-03-26 Thread David Laight
From: Gustavo A. R. Silva > Sent: 25 March 2021 21:12 > > On 3/25/21 10:29, David Laight wrote: > > >>> > >>> Could you use the simpler: > struct nfs_fhbase_new { > __u8 fb_version; > __u8 fb_auth_type; > __u8 fb_fsid_type; >

Re: [PATCH][next] UAPI: nfsfh.h: Replace one-element array with flexible-array member

2021-03-25 Thread Gustavo A. R. Silva
On 3/25/21 10:29, David Laight wrote: >>> >>> Could you use the simpler: struct nfs_fhbase_new { __u8 fb_version; __u8 fb_auth_type; __u8 fb_fsid_type; __u8 fb_fileid_type; union {

RE: [PATCH][next] UAPI: nfsfh.h: Replace one-element array with flexible-array member

2021-03-25 Thread David Laight
From: Gustavo A. R. Silva > Sent: 25 March 2021 13:18 > > On 3/25/21 08:45, David Laight wrote: > > From: Gustavo A. R. Silva > >> Sent: 23 March 2021 22:49 > >> > >> There is a regular need in the kernel to provide a way to declare having > >> a dynamically sized set of trailing elements in a str

Re: [PATCH][next] UAPI: nfsfh.h: Replace one-element array with flexible-array member

2021-03-25 Thread Gustavo A. R. Silva
On 3/25/21 08:45, David Laight wrote: > From: Gustavo A. R. Silva >> Sent: 23 March 2021 22:49 >> >> There is a regular need in the kernel to provide a way to declare having >> a dynamically sized set of trailing elements in a structure. Kernel code >> should always use “flexible array members”[

RE: [PATCH][next] UAPI: nfsfh.h: Replace one-element array with flexible-array member

2021-03-25 Thread David Laight
From: Gustavo A. R. Silva > Sent: 23 March 2021 22:49 > > There is a regular need in the kernel to provide a way to declare having > a dynamically sized set of trailing elements in a structure. Kernel code > should always use “flexible array members”[1] for these cases. The older > style of one-el

[PATCH][next] UAPI: nfsfh.h: Replace one-element array with flexible-array member

2021-03-23 Thread Gustavo A. R. Silva
There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2]. Use an