Re: [PATCH][next] USB: EHCI: ehci-mv: fix less than zero comparison of an unsigned int

2020-05-16 Thread Colin Ian King
On 16/05/2020 07:30, Greg Kroah-Hartman wrote: > On Fri, May 15, 2020 at 01:21:21PM -0400, Alan Stern wrote: >> On Fri, May 15, 2020 at 05:54:53PM +0100, Colin King wrote: >>> From: Colin Ian King >>> >>> The comparison of hcd->irq to less than zero for an error check will >>> never be true becaus

Re: [PATCH][next] USB: EHCI: ehci-mv: fix less than zero comparison of an unsigned int

2020-05-15 Thread Greg Kroah-Hartman
On Fri, May 15, 2020 at 01:21:21PM -0400, Alan Stern wrote: > On Fri, May 15, 2020 at 05:54:53PM +0100, Colin King wrote: > > From: Colin Ian King > > > > The comparison of hcd->irq to less than zero for an error check will > > never be true because hcd->irq is an unsigned int. Fix this by > > a

Re: [PATCH][next] USB: EHCI: ehci-mv: fix less than zero comparison of an unsigned int

2020-05-15 Thread Alan Stern
On Fri, May 15, 2020 at 06:26:04PM +0100, Colin Ian King wrote: > On 15/05/2020 18:21, Alan Stern wrote: > > On Fri, May 15, 2020 at 05:54:53PM +0100, Colin King wrote: > >> From: Colin Ian King > >> > >> The comparison of hcd->irq to less than zero for an error check will > >> never be true becau

Re: [PATCH][next] USB: EHCI: ehci-mv: fix less than zero comparison of an unsigned int

2020-05-15 Thread Colin Ian King
On 15/05/2020 18:21, Alan Stern wrote: > On Fri, May 15, 2020 at 05:54:53PM +0100, Colin King wrote: >> From: Colin Ian King >> >> The comparison of hcd->irq to less than zero for an error check will >> never be true because hcd->irq is an unsigned int. Fix this by >> assigning the int retval to

Re: [PATCH][next] USB: EHCI: ehci-mv: fix less than zero comparison of an unsigned int

2020-05-15 Thread Alan Stern
On Fri, May 15, 2020 at 05:54:53PM +0100, Colin King wrote: > From: Colin Ian King > > The comparison of hcd->irq to less than zero for an error check will > never be true because hcd->irq is an unsigned int. Fix this by > assigning the int retval to the return of platform_get_irq and checking >

[PATCH][next] USB: EHCI: ehci-mv: fix less than zero comparison of an unsigned int

2020-05-15 Thread Colin King
From: Colin Ian King The comparison of hcd->irq to less than zero for an error check will never be true because hcd->irq is an unsigned int. Fix this by assigning the int retval to the return of platform_get_irq and checking this for the -ve error condition and assigning hcd->irq to retval. Add