Re: [PATCH][next] bpf: remove redundant assignment to err

2019-06-06 Thread Dan Carpenter
On Mon, Jun 03, 2019 at 07:07:20PM +0100, Colin Ian King wrote: > On 03/06/2019 18:49, Jakub Kicinski wrote: > > On Mon, 3 Jun 2019 18:39:16 +0100, Colin Ian King wrote: > >> On 03/06/2019 18:21, Jakub Kicinski wrote: > >>> On Mon, 3 Jun 2019 18:02:47 +0100, Colin King wrote: > From: Colin

Re: [PATCH][next] bpf: remove redundant assignment to err

2019-06-03 Thread Colin Ian King
On 03/06/2019 18:49, Jakub Kicinski wrote: > On Mon, 3 Jun 2019 18:39:16 +0100, Colin Ian King wrote: >> On 03/06/2019 18:21, Jakub Kicinski wrote: >>> On Mon, 3 Jun 2019 18:02:47 +0100, Colin King wrote: From: Colin Ian King The variable err is assigned with the value -EINVAL th

Re: [PATCH][next] bpf: remove redundant assignment to err

2019-06-03 Thread Jakub Kicinski
On Mon, 3 Jun 2019 18:39:16 +0100, Colin Ian King wrote: > On 03/06/2019 18:21, Jakub Kicinski wrote: > > On Mon, 3 Jun 2019 18:02:47 +0100, Colin King wrote: > >> From: Colin Ian King > >> > >> The variable err is assigned with the value -EINVAL that is never > >> read and it is re-assigned a

Re: [PATCH][next] bpf: remove redundant assignment to err

2019-06-03 Thread Colin Ian King
On 03/06/2019 18:21, Jakub Kicinski wrote: > On Mon, 3 Jun 2019 18:02:47 +0100, Colin King wrote: >> From: Colin Ian King >> >> The variable err is assigned with the value -EINVAL that is never >> read and it is re-assigned a new value later on. The assignment is >> redundant and can be removed.

Re: [PATCH][next] bpf: remove redundant assignment to err

2019-06-03 Thread Jakub Kicinski
On Mon, 3 Jun 2019 18:02:47 +0100, Colin King wrote: > From: Colin Ian King > > The variable err is assigned with the value -EINVAL that is never > read and it is re-assigned a new value later on. The assignment is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Sign

[PATCH][next] bpf: remove redundant assignment to err

2019-06-03 Thread Colin King
From: Colin Ian King The variable err is assigned with the value -EINVAL that is never read and it is re-assigned a new value later on. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- kernel/bpf/devmap.c | 2 +- kernel/bpf