Re: [PATCH][next] drivers: thermal: processor_thermal_device: fix missing bitwise-or operator

2019-07-29 Thread Srinivas Pandruvada
On Mon, 2019-07-29 at 12:29 +0100, Colin Ian King wrote: > On 29/07/2019 12:24, walter harms wrote: > > > > > > Am 29.07.2019 12:29, schrieb Colin King: > > > From: Colin Ian King > > > > > > The variable val is having the top 8 bits cleared and then the > > > variable > > > is being re-assinge

Re: [PATCH][next] drivers: thermal: processor_thermal_device: fix missing bitwise-or operator

2019-07-29 Thread Colin Ian King
On 29/07/2019 12:24, walter harms wrote: > > > Am 29.07.2019 12:29, schrieb Colin King: >> From: Colin Ian King >> >> The variable val is having the top 8 bits cleared and then the variable >> is being re-assinged and setting just the top 8 bits. I believe the >> intention was bitwise-or in the

Re: [PATCH][next] drivers: thermal: processor_thermal_device: fix missing bitwise-or operator

2019-07-29 Thread walter harms
Am 29.07.2019 12:29, schrieb Colin King: > From: Colin Ian King > > The variable val is having the top 8 bits cleared and then the variable > is being re-assinged and setting just the top 8 bits. I believe the > intention was bitwise-or in the top 8 bits. Fix this by replacing > the = operat

[PATCH][next] drivers: thermal: processor_thermal_device: fix missing bitwise-or operator

2019-07-29 Thread Colin King
From: Colin Ian King The variable val is having the top 8 bits cleared and then the variable is being re-assinged and setting just the top 8 bits. I believe the intention was bitwise-or in the top 8 bits. Fix this by replacing the = operator with |= instead. Addresses-Coverity: ("Unused value"