Re: [PATCH][next] habanalabs: fix incorrect check on failed workqueue create

2020-08-09 Thread Oded Gabbay
On Sun, Aug 9, 2020 at 3:02 PM Greg Kroah-Hartman wrote: > > On Sun, Aug 09, 2020 at 02:02:18PM +0300, Oded Gabbay wrote: > > On Fri, Jul 31, 2020 at 9:21 AM Greg Kroah-Hartman > > wrote: > > > > > > On Thu, Jul 30, 2020 at 01:51:48PM +0300, Oded Gabbay wrote: > > > > On Thu, Jul 30, 2020 at 11:2

Re: [PATCH][next] habanalabs: fix incorrect check on failed workqueue create

2020-08-09 Thread Greg Kroah-Hartman
On Sun, Aug 09, 2020 at 02:02:18PM +0300, Oded Gabbay wrote: > On Fri, Jul 31, 2020 at 9:21 AM Greg Kroah-Hartman > wrote: > > > > On Thu, Jul 30, 2020 at 01:51:48PM +0300, Oded Gabbay wrote: > > > On Thu, Jul 30, 2020 at 11:20 AM Colin King > > > wrote: > > > > > > > > From: Colin Ian King > >

Re: [PATCH][next] habanalabs: fix incorrect check on failed workqueue create

2020-08-09 Thread Oded Gabbay
On Fri, Jul 31, 2020 at 9:21 AM Greg Kroah-Hartman wrote: > > On Thu, Jul 30, 2020 at 01:51:48PM +0300, Oded Gabbay wrote: > > On Thu, Jul 30, 2020 at 11:20 AM Colin King > > wrote: > > > > > > From: Colin Ian King > > > > > > The null check on a failed workqueue create is currently null checki

Re: [PATCH][next] habanalabs: fix incorrect check on failed workqueue create

2020-07-30 Thread Greg Kroah-Hartman
On Thu, Jul 30, 2020 at 01:51:48PM +0300, Oded Gabbay wrote: > On Thu, Jul 30, 2020 at 11:20 AM Colin King wrote: > > > > From: Colin Ian King > > > > The null check on a failed workqueue create is currently null checking > > hdev->cq_wq rather than the pointer hdev->cq_wq[i] and so the test > >

Re: [PATCH][next] habanalabs: fix incorrect check on failed workqueue create

2020-07-30 Thread Oded Gabbay
On Thu, Jul 30, 2020 at 11:20 AM Colin King wrote: > > From: Colin Ian King > > The null check on a failed workqueue create is currently null checking > hdev->cq_wq rather than the pointer hdev->cq_wq[i] and so the test > will never be true on a failed workqueue create. Fix this by checking > hde

[PATCH][next] habanalabs: fix incorrect check on failed workqueue create

2020-07-30 Thread Colin King
From: Colin Ian King The null check on a failed workqueue create is currently null checking hdev->cq_wq rather than the pointer hdev->cq_wq[i] and so the test will never be true on a failed workqueue create. Fix this by checking hdev->cq_wq[i]. Addresses-Coverity: ("Dereference before null check