Re: [PATCH][next] net: phy: dp83869: fix unsigned comparisons against less than zero values

2020-10-06 Thread Dan Carpenter
On Fri, Oct 02, 2020 at 12:26:49PM -0500, Dan Murphy wrote: > Colin > > On 10/2/20 11:54 AM, Colin King wrote: > > From: Colin Ian King > > > > Currently the comparisons of u16 integers value and sopass_val with > > less than zero for error checking is always false because the values > > are

Re: [PATCH][next] net: phy: dp83869: fix unsigned comparisons against less than zero values

2020-10-03 Thread David Miller
From: Colin King Date: Fri, 2 Oct 2020 17:54:22 +0100 > From: Colin Ian King > > Currently the comparisons of u16 integers value and sopass_val with > less than zero for error checking is always false because the values > are unsigned. Fix this by making these variables int. This does not >

Re: [PATCH][next] net: phy: dp83869: fix unsigned comparisons against less than zero values

2020-10-02 Thread Andrew Lunn
On Fri, Oct 02, 2020 at 12:26:49PM -0500, Dan Murphy wrote: > Colin > > On 10/2/20 11:54 AM, Colin King wrote: > > From: Colin Ian King > > > > Currently the comparisons of u16 integers value and sopass_val with > > less than zero for error checking is always false because the values > > are

Re: [PATCH][next] net: phy: dp83869: fix unsigned comparisons against less than zero values

2020-10-02 Thread Dan Murphy
Colin On 10/2/20 11:54 AM, Colin King wrote: From: Colin Ian King Currently the comparisons of u16 integers value and sopass_val with less than zero for error checking is always false because the values are unsigned. Fix this by making these variables int. This does not affect the shift and

[PATCH][next] net: phy: dp83869: fix unsigned comparisons against less than zero values

2020-10-02 Thread Colin King
From: Colin Ian King Currently the comparisons of u16 integers value and sopass_val with less than zero for error checking is always false because the values are unsigned. Fix this by making these variables int. This does not affect the shift and mask operations performed on these variables